-
Notifications
You must be signed in to change notification settings - Fork 349
[WIP] Support .NET 10 #2822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] Support .NET 10 #2822
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2822 +/- ##
==========================================
- Coverage 70.04% 70.00% -0.05%
==========================================
Files 429 439 +10
Lines 16838 16890 +52
==========================================
+ Hits 11794 11823 +29
- Misses 5044 5067 +23 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Need to investigate macOS test failure with .NET 10. I don't have a Macbook so might be tricky:
|
Due to changes in dotnet/runtime#113041. |
4bf19ef
to
8977897
Compare
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
8977897
to
6e25f07
Compare
Cherry-pick various changes from open-telemetry#2822: - Fix incorrect version comment on CodeQL actions. - Explicitly disable use of pre-release .NET SDK versions. - Fix incorrect comment. - Make System.Text.Json package reference conditional to avoid explicit dependency when the package in "in-box". - Fix typo in test name. - Add support for a maximum version for routing test cases. - Allow the metric path for routing test cases to diverge from the activity path.
60e8017
to
482d51b
Compare
482d51b
to
8161a43
Compare
Add support for building and testing with .NET 10, initially using .NET 10 preview 4.
Update to preview 5 of .NET 10.
Update to preview 6 of .NET 10.
Fix another NU1510 warning.
Fix AoT NU1510 warnings.
Fix another NU1510 warning about `System.Text.Json`.
Update tests for behaviour change from dotnet/runtime#115959.
Move comments.
Update to preview 5 for Cassandra and update digests.
Update to preview 7 of .NET 10.
- Add test for Blazor activities in .NET 10. - Fix typos.
- Update to release candidate 1 of .NET 10. - Remove obsolete `IWebHost` usage.
Update globla.json so that actions/setup-dotnet works correctly with rc.1 vs preview.7.
Fix test broken by change in behaviour in .NET 10.
8161a43
to
0347a41
Compare
@martincostello with dotnet/runtime#116269 and dotnet/runtime#115959 available in .NET 10, the HttpClient native instrumentation now records exceptions. I think you can condition the following lines to apply them only for versions before 10: Lines 181 to 202 in fabb87f
In the same way that some attributes are set only for versions before 9 (because runtime does it from this version): Line 140 in fabb87f
|
When running under .NET 10 skip code that duplicates built-in functionality.
Changes
Add support for building and testing with .NET 10.
Initially using .NET 10 preview 4, will update as previews progress.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes