Skip to content

Conversation

evgenyfedorov2
Copy link
Contributor

@evgenyfedorov2 evgenyfedorov2 commented Sep 9, 2025

Changes

Renamed some extension methods from AddTraceEnricher* to TryAddTraceEnricher* to better convey the idea of idempotency -duplicate registrations are not allowed nor make sense.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@evgenyfedorov2 evgenyfedorov2 requested a review from a team as a code owner September 9, 2025 08:47
@github-actions github-actions bot added documentation Improvements or additions to documentation comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment labels Sep 9, 2025
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.80%. Comparing base (dc6cf9e) to head (73f94cf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3085      +/-   ##
==========================================
+ Coverage   69.60%   69.80%   +0.19%     
==========================================
  Files         420      410      -10     
  Lines       16317    16199     -118     
==========================================
- Hits        11358    11308      -50     
+ Misses       4959     4891      -68     
Flag Coverage Δ
unittests-Extensions 90.65% <ø> (ø)
unittests-Extensions.Enrichment 100.00% <100.00%> (ø)
unittests-Instrumentation.Cassandra ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...chment/TraceEnrichmentProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
...ment/TraceEnrichmentServiceCollectionExtensions.cs 100.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@evgenyfedorov2 evgenyfedorov2 force-pushed the users/evgenyfedorov2/rename_enrichnment_extensions branch from bfcb200 to 9418308 Compare September 9, 2025 08:51
@evgenyfedorov2 evgenyfedorov2 force-pushed the users/evgenyfedorov2/rename_enrichnment_extensions branch from 9418308 to c7344d1 Compare September 9, 2025 08:53
Copy link
Contributor

@dariusclay dariusclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, better naming to match underlying behavior

@Kielek Kielek merged commit c8c60c4 into open-telemetry:main Sep 9, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:extensions.enrichment Things related to OpenTelemetry.Extensions.Enrichment documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants