Use new faas attributes #3086

[thompson-tomo]

Fixes #3086
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

• CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
• Unit tests added/updated
• Appropriate CHANGELOG.md files updated for non-trivial changes
• Changes in public API reviewed (if applicable)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.65%. Comparing base (dc6cf9e) to head (182d828).
⚠️ Report is 44 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3087      +/-   ##
==========================================
+ Coverage   69.60%   69.65%   +0.04%     
==========================================
  Files         420      420              
  Lines       16317    16318       +1     
==========================================
+ Hits        11358    11366       +8     
+ Misses       4959     4952       -7     

Flag	Coverage Δ
unittests-Contrib.Shared.Tests	83.73% <ø> (ø)
unittests-Exporter.Geneva	53.47% <ø> (+0.13%)	⬆️
unittests-Exporter.InfluxDB	95.14% <ø> (ø)
unittests-Exporter.Instana	74.86% <ø> (ø)
unittests-Exporter.OneCollector	94.61% <ø> (ø)
unittests-Extensions	90.65% <ø> (ø)
unittests-Extensions.Enrichment	100.00% <ø> (ø)
unittests-Extensions.Enrichment.AspNetCore	94.11% <ø> (ø)
unittests-Instrumentation.AWS	83.50% <100.00%> (-0.31%)	⬇️
unittests-Instrumentation.AspNet	75.18% <ø> (+0.24%)	⬆️
unittests-Instrumentation.AspNetCore	70.76% <ø> (ø)
unittests-Instrumentation.Cassandra	23.52% <ø> (ø)
unittests-Instrumentation.ConfluentKafka	14.10% <ø> (ø)
unittests-Instrumentation.ElasticsearchClient	80.12% <ø> (ø)
unittests-Instrumentation.EntityFrameworkCore	80.56% <ø> (ø)
unittests-Instrumentation.EventCounters	76.36% <ø> (ø)
unittests-Instrumentation.GrpcCore	91.42% <ø> (ø)
unittests-Instrumentation.GrpcNetClient	79.61% <ø> (ø)
unittests-Instrumentation.Hangfire	84.61% <ø> (ø)
unittests-Instrumentation.Http	74.18% <ø> (ø)
unittests-Instrumentation.Owin	88.62% <ø> (ø)
unittests-Instrumentation.Process	100.00% <ø> (ø)
unittests-Instrumentation.Quartz	78.76% <ø> (ø)
unittests-Instrumentation.Runtime	100.00% <ø> (ø)
unittests-Instrumentation.ServiceFabricRemoting	34.54% <ø> (ø)
unittests-Instrumentation.SqlClient	86.68% <ø> (ø)
unittests-Instrumentation.StackExchangeRedis	70.31% <ø> (ø)
unittests-Instrumentation.Wcf	78.95% <ø> (ø)
unittests-OpAmp.Client	61.08% <ø> (ø)
unittests-PersistentStorage	65.88% <ø> (+0.66%)	⬆️
unittests-Resources.Azure	85.31% <ø> (ø)
unittests-Resources.Container	67.34% <ø> (ø)
unittests-Resources.Gcp	71.42% <ø> (ø)
unittests-Resources.Host	73.91% <ø> (ø)
unittests-Resources.OperatingSystem	76.98% <ø> (ø)
unittests-Resources.Process	100.00% <ø> (ø)
unittests-Resources.ProcessRuntime	79.59% <ø> (ø)
unittests-Sampler.AWS	88.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...Lambda/Implementation/AWSLambdaResourceDetector.cs	100.00% <100.00%> (ø)
...ntation.AWSLambda/Implementation/AWSLambdaUtils.cs	82.02% <100.00%> (-0.74%)	⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Oberon00]

At the moment it seems the corresponding spec PRs are not merged. We should definitely wait until then (I see it's a draft anyways) I didn't read them through yet, but even if they are merged, would it be possible to also keep setting cloud.resource_id in addition to the new name? We originally had faas.id before switching to cloud.resource_id, it seems now we are flipping back into the other direction. Would be nice to have some stability...

[Kielek]

At the moment it seems the corresponding spec PRs are not merged. We should definitely wait until then (I see it's a draft anyways) I didn't read them through yet, but even if they are merged, would it be possible to also keep setting cloud.resource_id in addition to the new name? We originally had faas.id before switching to cloud.resource_id, it seems now we are flipping back into the other direction. Would be nice to have some stability...

@Oberon00, could you please share your thoughts in semantic convention PRs?

[thompson-tomo]

Correct they are not merged and request was for an implementation and obviously this would only transition to ready once merged.

Yes the cloud.resource.id could be kept on the span. The difficulty with current solution we don't have a distinct way to identify a faas function based on attributes which also works for non cloud providers.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[github-actions]

Closed as inactive. Feel free to reopen if this PR is still being worked on.