-
Notifications
You must be signed in to change notification settings - Fork 352
[OpAMP.Client] Add heartbeats #3095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3095 +/- ##
==========================================
+ Coverage 69.82% 70.02% +0.20%
==========================================
Files 426 420 -6
Lines 16495 16559 +64
==========================================
+ Hits 11517 11595 +78
+ Misses 4978 4964 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
src/OpenTelemetry.OpAmp.Client/Internal/Services/Heartbeat/HeartbeatService.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.OpAmp.Client/Internal/Services/Heartbeat/HeartbeatService.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.OpAmp.Client/Internal/Services/Heartbeat/HeartbeatService.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.OpAmp.Client/Internal/Settings/HeartbeatSettings.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Costello <[email protected]>
…rtbeatService.cs Co-authored-by: Martin Costello <[email protected]>
…ings.cs Co-authored-by: Martin Costello <[email protected]>
…rtbeatService.cs Co-authored-by: Martin Costello <[email protected]>
src/OpenTelemetry.OpAmp.Client/Internal/Services/Heartbeat/HeartbeatService.cs
Outdated
Show resolved
Hide resolved
| } | ||
| catch (Exception ex) | ||
| { | ||
| // TODO: change to proper logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentionally left for follow ups?
For now, all contrib packages are using EventSources similar to https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/8452d88e83e1c204bd4b43c7c3d8189f94ff87be/src/OpenTelemetry.Resources.Host/HostResourceEventSource.cs
(There are even tests for it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that was my plan as well. Will address logging in a separate PR.
Changes
Adds heartbeats to support http transport scenario.
There is no client side api yet to provide info about components etc. Only reports static heartbeats.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes