Fix RecursionError by preventing duplicate instrumentation in urllib3 #3974
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a guard (_instrumented flag) to prevent urllib3 instrumentation from running multiple times, which caused RecursionError (#4532). This ensures _instrument() exits early if already applied.
|
|
Contributor
|
@shrxya07 thanks for the PR, how do you reproduce it? Is it manual calling the instrumentor more than one time or in a different way? Please add a test, an entry in changelog and setup pre-commit so CI will be happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes RecursionError reported in issue #4532.
Fix
A
_instrumentedguard flag was added to urllib3 instrumentation to ensurethat
_instrument()cannot run multiple times. The absence of this guardcaused recursive instrumentation and eventually RecursionError.
Details
The change:
_instrumented = Falseat the class level_instrument()if instrumentation already happenedResult
This prevents infinite recursion and ensures stable instrumentation behavior.
Fixes: #4532