Skip to content

Fix RecursionError by preventing duplicate instrumentation in urllib3 #3974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

Fix RecursionError by preventing duplicate instrumentation in urllib3 #3974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...entelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ class RequestInfo:
class URLLib3Instrumentor(BaseInstrumentor):
def instrumentation_dependencies(self) -> Collection[str]:
return _instruments

_instrumented = False
def _instrument(self, **kwargs):
"""Instruments the urllib3 module

Expand All @@ -214,6 +214,9 @@ def _instrument(self, **kwargs):
list of regexes used to exclude URLs from tracking
"""
# initialize semantic conventions opt-in if needed
if self._instrumented:
return
self._instrumented = True
_OpenTelemetrySemanticConventionStability._initialize()
sem_conv_opt_in_mode = _OpenTelemetrySemanticConventionStability._get_opentelemetry_stability_opt_in_mode(
_OpenTelemetryStabilitySignalType.HTTP,
Expand Down