WEB-322: Re-aging: Interest handling configuration with id

[alberto-art3ch]

Description

Re-aging: Interest handling configuration with id value instead of code value

Related issues and discussion

WEB-322

Screenshots

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• If you have multiple commits please combine them into one commit by squashing them.

• Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

• Bug Fixes
  • Corrected the mapping of interest handling options in the Loan Re-Aging form. Selections now reliably apply the intended option, preventing mismatches between the displayed choice and the saved value.
  • Ensures consistent behavior when selecting or updating interest handling during re-aging, improving accuracy in both new selections and edits.
  • Enhances overall reliability of the loan re-aging workflow without altering the user interface or introducing new steps.

[coderabbitai]

Walkthrough

Updated a template binding in the loan re-aging component to use the option’s id instead of code for mat-option value. No other files or logic were changed.

Changes

Cohort / File(s)	Summary of changes
Loan re-aging template src/app/loans/loans-view/loan-account-actions/loan-reaging/loan-reaging.component.html	Changed mat-option value binding from reAgeInterestHandlingOption.code to reAgeInterestHandlingOption.id.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

• gkbishnoi07
• adamsaghy

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly reflects the primary change—updating the re-aging interest handling configuration to use an id value—and is concise and specific to the PR’s scope.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a46b58 and bebffb4.

📒 Files selected for processing (1)

• src/app/loans/loans-view/loan-account-actions/loan-reaging/loan-reaging.component.html (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/app/**

⚙️ CodeRabbit configuration file

src/app/**: For Angular code: verify component separation, trackBy on *ngFor,
strict type safety, and clean observable patterns.

Files:

• src/app/loans/loans-view/loan-account-actions/loan-reaging/loan-reaging.component.html

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Run Lint, Build and Deploy

🔇 Additional comments (1)

src/app/loans/loans-view/loan-account-actions/loan-reaging/loan-reaging.component.html (1)

46-51: Confirm id matches form control expectation.

The template now binds the option value to reAgeInterestHandlingOption.id. Please double-check that reagingLoanForm.get('reAgeInterestHandling') and its backing model/service expect an ID (number?) rather than the previous code string so we don’t introduce a type mismatch or submission regression. If everything downstream already consumes IDs, we’re good; otherwise update the form/control handling as needed.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[steinwinde]

LGTM