Skip to content

Conversation

@mattishii26
Copy link
Contributor

@mattishii26 mattishii26 commented Oct 15, 2025

Description

  • fix: Trace view padding to match Log/Trace view
  • fix: Tabs panel to not have a background and border

Issues Resolved

  • Trace detail page, reduce panel spacing
  • Trace detail > Remove panel border around tabs

Screenshot

Screenshot 2025-10-15 at 3 04 49 PM image

Testing the changes

Changelog

  • fix: Trace view padding to match Log/Trace view
  • fix: Tabs panel to not have a background and border

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.35%. Comparing base (bdc3199) to head (c34ffd2).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10731      +/-   ##
==========================================
- Coverage   60.36%   60.35%   -0.02%     
==========================================
  Files        4463     4462       -1     
  Lines      119589   119393     -196     
  Branches    19771    19716      -55     
==========================================
- Hits        72189    72057     -132     
+ Misses      42391    42349      -42     
+ Partials     5009     4987      -22     
Flag Coverage Δ
Linux_1 26.58% <ø> (ø)
Linux_2 38.82% <ø> (ø)
Linux_3 38.89% <ø> (+<0.01%) ⬆️
Linux_4 ?
Windows_1 26.60% <ø> (ø)
Windows_2 38.79% <ø> (ø)
Windows_3 38.90% <ø> (-0.01%) ⬇️
Windows_4 32.99% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kamingleung
Copy link

@mattishii26 Does this PR also covers extending the left panel to the bottom edge of the browser window? It should match the height of the right side panel:
image

@yanatha99
Copy link
Contributor

@mattishii26 Does this PR also covers extending the left panel to the bottom edge of the browser window? It should match the height of the right side panel: image

This #10725 partially addresses that issue. There's a comment starting on line 185 of span_hierarchy_table that explains the partial fix and what's needed for ideal solution. The ideal solution can be taken up as an item after 10/20 code freeze, we're already cutting it too close.

@yanatha99
Copy link
Contributor

Just a reminder: DO NOT merge this PR. Merge #10745 instead.

@TackAdam TackAdam closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants