Skip to content

Conversation

yanatha99
Copy link
Contributor

Description

This PR combines the following PRs to resolve merge conflicts and proactively handle any potential interaction bugs between the changes by testing them all together

Additional commits not from those PRs

  • fix: change span overview service identifier to operation @yanatha99 - Span Overview tab service identifier now correctly uses the span operation instead of service name
  • chore: Improve SpanStatusFilter unit testing @yanatha99

Screenshot

Can view the recordings/screenshots from the listed PRs to see each of the changes separately.

How Trace details looks with all these changes together.
trace-details-after-changes

Testing the changes

Follow the testing steps in the linked PRs.

To test fix: change span overview service identifier to operation

  1. Go to Discover Traces page
  2. Note the "Service identifier" of any span in the table
  3. Click the "Time" link of that span to open the trace detail flyout
  4. In the flyout look at the Span details Overview tab and verify the "Service identifier" there matches (2)

Changelog

  • feat: Add span status filters to trace details. Combine bug fixes.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Nathan Yang and others added 7 commits October 17, 2025 01:23
Signed-off-by: Kakshak Pravin Porwal <[email protected]>
Signed-off-by: Nathan Yang <[email protected]>
…rent with no border

Signed-off-by: Matthew Ishii <[email protected]>
Signed-off-by: Nathan Yang <[email protected]>
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 88.23529% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.50%. Comparing base (7327626) to head (a7df8fb).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...lication/pages/traces/trace_details/trace_view.tsx 61.53% 3 Missing and 2 partials ⚠️
...c/traces/span_detail_tables/span_status_filter.tsx 92.50% 1 Missing and 2 partials ⚠️
...race_details/public/traces/ppl_resolve_helpers.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10745      +/-   ##
==========================================
+ Coverage   60.47%   60.50%   +0.02%     
==========================================
  Files        4484     4485       +1     
  Lines      120115   120178      +63     
  Branches    19892    19909      +17     
==========================================
+ Hits        72641    72709      +68     
+ Misses      42431    42426       -5     
  Partials     5043     5043              
Flag Coverage Δ
Linux_1 26.58% <ø> (ø)
Linux_2 38.82% <ø> (ø)
Linux_3 39.06% <ø> (ø)
Linux_4 33.28% <88.23%> (+0.05%) ⬆️
Windows_1 26.59% <ø> (ø)
Windows_2 38.79% <ø> (ø)
Windows_3 39.07% <ø> (ø)
Windows_4 33.28% <88.23%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yanatha99
Copy link
Contributor Author

After discussion with @TackAdam going to fast follow this to change span status filter to only allow single selection at a time.

@TackAdam
Copy link
Collaborator

Callout as fast fallow:
Switch the filter by spans to be single select instead of and clause.
Screenshot 2025-10-17 at 10 49 37 AM

@TackAdam TackAdam added OSD Changes being merged by the OSD team Cypress-test PR contains Cypress test change labels Oct 17, 2025
@yanatha99
Copy link
Contributor Author

yanatha99 commented Oct 17, 2025

Fast follow changes

  1. Change SpanStatusFilter from multi-select to single-select
  2. Render SpanStatusFilter as FC
  3. Remove empty function passed to setSpanFiltersWithStorage and add non-null assertion
  4. Remove isSpanOk function, just directly use !isSpanError
  5. Add new lines for styling on copy icon

@TackAdam TackAdam merged commit def8b93 into opensearch-project:main Oct 20, 2025
178 of 182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cypress-test PR contains Cypress test change OSD Changes being merged by the OSD team repeat-contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants