-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Trace:Details Add span status filters. Combine bug fixes. #10745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nathan Yang <[email protected]>
Signed-off-by: Nathan Yang <[email protected]>
Signed-off-by: Kakshak Pravin Porwal <[email protected]> Signed-off-by: Nathan Yang <[email protected]>
Signed-off-by: Matthew Ishii <[email protected]> Signed-off-by: Nathan Yang <[email protected]>
Signed-off-by: Nathan Yang <[email protected]>
…rent with no border Signed-off-by: Matthew Ishii <[email protected]> Signed-off-by: Nathan Yang <[email protected]>
Signed-off-by: Nathan Yang <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10745 +/- ##
==========================================
+ Coverage 60.47% 60.50% +0.02%
==========================================
Files 4484 4485 +1
Lines 120115 120178 +63
Branches 19892 19909 +17
==========================================
+ Hits 72641 72709 +68
+ Misses 42431 42426 -5
Partials 5043 5043
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
After discussion with @TackAdam going to fast follow this to change span status filter to only allow single selection at a time. |
.../explore/public/application/pages/traces/trace_details/public/traces/ppl_resolve_helpers.tsx
Show resolved
Hide resolved
...ication/pages/traces/trace_details/public/traces/span_detail_tables/span_hierarchy_table.tsx
Show resolved
Hide resolved
src/plugins/explore/public/application/pages/traces/trace_details/public/top_nav_buttons.tsx
Show resolved
Hide resolved
src/plugins/explore/public/application/pages/traces/trace_details/public/top_nav_buttons.tsx
Show resolved
Hide resolved
Fast follow changes
|
Description
This PR combines the following PRs to resolve merge conflicts and proactively handle any potential interaction bugs between the changes by testing them all together
Can view those PR's for more detailed description of each change
Additional commits not from those PRs
fix: change span overview service identifier to operation
@yanatha99 - Span Overview tab service identifier now correctly uses the span operation instead of service namechore: Improve SpanStatusFilter unit testing
@yanatha99Screenshot
Can view the recordings/screenshots from the listed PRs to see each of the changes separately.
How Trace details looks with all these changes together.

Testing the changes
Follow the testing steps in the linked PRs.
To test
fix: change span overview service identifier to operation
Changelog
Check List
yarn test:jest
yarn test:jest_integration