Skip to content

Conversation

mattishii26
Copy link
Contributor

@mattishii26 mattishii26 commented Oct 16, 2025

Description

  • Traces detail page > Span details. Move copy icon to the right of the value
  • Trace detail page > Add copy icon to Trace ID badge

Issues Resolved

  • Traces detail page > Span details. Move copy icon to the right of the value
  • Trace detail page > Add copy icon to Trace ID badge

Screenshot

image image image

Testing the changes

Manual testing and unit tests

Changelog

  • fix: Add copy icon for Trace ID
  • fix: Relocate copy icon for Span overview to be on left side

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to mattishii26/OpenSearch-Dashboards that referenced this pull request Oct 16, 2025
@kamingleung
Copy link

@mattishii26 Thank you for the updates. The icon should be placed at the end of the text string:
image

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.46%. Comparing base (464dfe2) to head (dd01ec1).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10739   +/-   ##
=======================================
  Coverage   60.46%   60.46%           
=======================================
  Files        4482     4482           
  Lines      120061   120061           
  Branches    19884    19884           
=======================================
  Hits        72596    72596           
  Misses      42425    42425           
  Partials     5040     5040           
Flag Coverage Δ
Linux_1 26.58% <ø> (ø)
Linux_2 38.82% <ø> (ø)
Linux_3 ?
Linux_4 33.22% <ø> (ø)
Windows_1 26.59% <ø> (ø)
Windows_2 38.79% <ø> (ø)
Windows_3 39.04% <ø> (+<0.01%) ⬆️
Windows_4 33.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattishii26
Copy link
Contributor Author

@kamingleung ACK, will make that change. Thanks!

@mattishii26 mattishii26 force-pushed the bugfix/addAndMoveCopyIconsInTraceDetailView branch from 4d5616f to 3b4109e Compare October 16, 2025 23:35
@yanatha99
Copy link
Contributor

Just a reminder: DO NOT merge this PR. Merge #10745 instead.

@TackAdam TackAdam closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants