fix(breadcrumbs): trailing link should still clickable if hide last breadcrumb #10897
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ast breadcrumb The changes opensearch-project#10507 causes Visualize/Dashboards not clickable when open a visualization or dashboard, this prevent user from navigating back to visualization list or dashboard list from breadcrumbs. Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
Maosaic,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
bandinib-amzn,
curq,
d-buckner,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ps48,
raintygao,
sejli,
virajsanghvi,
wanglam,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
ruanyl
requested review from
TackAdam,
paulstn,
ruchidh and
sumukhswamy
as code owners
Contributor
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
7 tasks
Hailong-am
previously approved these changes
Nov 11, 2025
wanglam
previously approved these changes
Nov 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10897 +/- ##
=======================================
Coverage 60.76% 60.76%
=======================================
Files 4533 4533
Lines 122129 122164 +35
Branches 20461 20471 +10
=======================================
+ Hits 74207 74232 +25
- Misses 42689 42695 +6
- Partials 5233 5237 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SuZhou-Joe
previously approved these changes
Nov 11, 2025
Signed-off-by: Yulong Ruan <[email protected]>
ruanyl
dismissed stale reviews from SuZhou-Joe, wanglam, and Hailong-am
via
e07bc43
Member
Author
|
Checked the failed tests are unrelated, merge now |
angle943
approved these changes
Nov 11, 2025
LDrago27
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes #10507 causes Visualize/Dashboards not clickable when open a visualization or dashboard, this prevent user from navigating back to visualization list or dashboard list from breadcrumbs.
Before
After
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration