Skip to content

Conversation

@varunbharadwaj
Copy link
Contributor

@varunbharadwaj varunbharadwaj commented Oct 22, 2025

Description

File-based indexing test, especially FileBasedIngestionSingleNodeTests.testFileIngestionFromLatestPointer has been marked flaky as it fails expecting 0 results, but returns 2.

This could happen if the file contents are not visible at the time of poller initialization. This PR updates the setup stage to ensure the file contents are visible.

However, this could not be reproduced locally even on running 500 iterations. We'll monitor if the issue is solved after this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

✅ Gradle check result for 2d03d63: SUCCESS

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.18%. Comparing base (8feb6e1) to head (2d03d63).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19735      +/-   ##
============================================
+ Coverage     73.11%   73.18%   +0.06%     
- Complexity    70823    70882      +59     
============================================
  Files          5732     5732              
  Lines        324255   324255              
  Branches      46924    46924              
============================================
+ Hits         237087   237306     +219     
+ Misses        68076    67843     -233     
- Partials      19092    19106      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@varunbharadwaj varunbharadwaj marked this pull request as ready for review October 22, 2025 22:37
@varunbharadwaj varunbharadwaj requested a review from a team as a code owner October 22, 2025 22:37
@msfroh msfroh merged commit 68d868a into opensearch-project:main Oct 22, 2025
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants