Skip to content

Fix flaky file-based indexing tests #19735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

Fix flaky file-based indexing tests #19735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...s/src/test/java/org/opensearch/plugin/ingestion/fs/FileBasedIngestionSingleNodeTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,15 @@ public void setupIngestionFile() throws Exception {
try (FileChannel channel = FileChannel.open(shardFile, StandardOpenOption.READ)) {
channel.force(true);
}

// Wait for file to be fully visible by reading it back
// This prevents race conditions where tests start before file is ready
assertBusy(() -> {
java.util.List<String> lines = Files.readAllLines(shardFile, StandardCharsets.UTF_8);
assertEquals("File should have exactly 2 lines", 2, lines.size());
assertTrue("First line should contain alice", lines.get(0).contains("alice"));
assertTrue("Second line should contain bob", lines.get(1).contains("bob"));
});
}

public void testFileIngestion() throws Exception {
Expand Down
Loading