mockgen deprecated: use uber-go/mock instead#607
mockgen deprecated: use uber-go/mock instead#607sebrandon1 wants to merge 2 commits intoopenshift:masterfrom
Conversation
sebrandon1
force-pushed
the
mockgen_deprecation
branch
from
acd2024 to
86ada25
Compare
sebrandon1
force-pushed
the
mockgen_deprecation
branch
from
86ada25 to
131c9e8
Compare
openshift-merge-robot
added
the
needs-rebase
sebrandon1
force-pushed
the
mockgen_deprecation
branch
from
131c9e8 to
7c579e4
Compare
openshift-merge-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sebrandon1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The test files were still importing github.com/golang/mock/gomock instead of go.uber.org/mock/gomock, causing type mismatch errors when the mocks were regenerated with uber-go/mock.
sebrandon1
force-pushed
the
mockgen_deprecation
branch
from
7c579e4 to
9a92161
Compare
|
@sebrandon1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
https://github.com/golang/mock is marked as archived as of
June 27, 2023. They recommend using go.uber.org/mock.This PR attempts to change the dependency to one that is maintained.
Tracking issue: redhat-best-practices-for-k8s/telco-bot#45