Skip to content

mockgen deprecated: use uber-go/mock instead #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebrandon1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

mockgen deprecated: use uber-go/mock instead #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44ef39d
mockgen deprecated: use uber-go/mock instead
sebrandon1 Nov 13, 2025
9a92161
Update test files to use uber-go/mock import
sebrandon1 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ require (
github.com/spf13/cobra v1.10.2
github.com/thedevsaddam/retry v1.2.1
github.com/thoas/go-funk v0.9.3
go.uber.org/mock v0.6.0
golang.org/x/crypto v0.47.0
golang.org/x/term v0.39.0
k8s.io/api v0.30.3
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,6 +1288,8 @@ go.uber.org/atomic v1.3.2/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/atomic v1.4.0/go.mod h1:gD2HeocX3+yG+ygLZcrzQJaqmWj9AIm7n08wl/qW/PE=
go.uber.org/goleak v1.3.0 h1:2K3zAYmnTNqV73imy9J1T3WC+gmCePx2hEGkimedGto=
go.uber.org/goleak v1.3.0/go.mod h1:CoHD4mav9JJNrW/WLlf7HGZPjdw8EucARQHekz1X6bE=
go.uber.org/mock v0.6.0 h1:hyF9dfmbgIX5EfOdasqLsWD6xqpNZlXblLB/Dbnwv3Y=
go.uber.org/mock v0.6.0/go.mod h1:KiVJ4BqZJaMj4svdfmHM0AUx4NJYO8ZNpPnZn1Z+BBU=
go.uber.org/multierr v1.1.0/go.mod h1:wR5kodmAFQ0UK8QlbwjlSNy0Z68gJhDJUG5sjR94q/0=
go.uber.org/multierr v1.11.0 h1:blXXJkSxSSfBVBlC76pxqeO+LN3aDfLQo+309xJstO0=
go.uber.org/multierr v1.11.0/go.mod h1:20+QtiLqy0Nd6FdQB9TLXag12DsQkrbs3htMFfDN80Y=
Expand Down
2 changes: 1 addition & 1 deletion pkg/asset/config/env_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ func (e *EnvConfig) FindInAssets(filePattern string) string {
}

// FindFilesInCache returns the files from cache whose name match the given regexp.
func (e *EnvConfig) FindFilesInCache(pattern string) (files []*asset.File, err error) {
func (e *EnvConfig) FindFilesInCache(pattern string) (files []*asset.File, err error) {
matches, err := filepath.Glob(filepath.Join(e.CacheDir, pattern))
if err != nil {
return nil, err
Expand Down
2 changes: 1 addition & 1 deletion pkg/coreos/coreos_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"github.com/go-openapi/swag"
"github.com/openshift/appliance/pkg/types"

"github.com/golang/mock/gomock"
"go.uber.org/mock/gomock"
. "github.com/onsi/ginkgo/v2/dsl/core"
. "github.com/onsi/gomega"
"github.com/openshift/appliance/pkg/asset/config"
Expand Down
3 changes: 2 additions & 1 deletion pkg/executer/mock_executer.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/genisoimage/genisoimage_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"fmt"
"testing"

"github.com/golang/mock/gomock"
"go.uber.org/mock/gomock"
. "github.com/onsi/ginkgo/v2/dsl/core"
. "github.com/onsi/gomega"
"github.com/openshift/appliance/pkg/executer"
Expand Down
14 changes: 10 additions & 4 deletions pkg/ignition/mock_ignition.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/installer/installer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"github.com/openshift/appliance/pkg/release"
"github.com/openshift/appliance/pkg/types"

"github.com/golang/mock/gomock"
"go.uber.org/mock/gomock"
. "github.com/onsi/ginkgo/v2/dsl/core"
. "github.com/onsi/gomega"
"github.com/openshift/appliance/pkg/asset/config"
Expand Down
2 changes: 1 addition & 1 deletion pkg/registry/registry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"strings"
"testing"

"github.com/golang/mock/gomock"
"go.uber.org/mock/gomock"
. "github.com/onsi/ginkgo/v2/dsl/core"
. "github.com/onsi/ginkgo/v2/dsl/table"
. "github.com/onsi/gomega"
Expand Down
40 changes: 24 additions & 16 deletions pkg/release/mock_release.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/release/release_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"testing"

"github.com/go-openapi/swag"
"github.com/golang/mock/gomock"
"go.uber.org/mock/gomock"
. "github.com/onsi/ginkgo/v2/dsl/core"
. "github.com/onsi/gomega"
"github.com/openshift/appliance/pkg/asset/config"
Expand Down
2 changes: 1 addition & 1 deletion pkg/skopeo/skopeo_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

"github.com/openshift/appliance/pkg/consts"

"github.com/golang/mock/gomock"
"go.uber.org/mock/gomock"
. "github.com/onsi/ginkgo/v2/dsl/core"
. "github.com/onsi/gomega"
"github.com/openshift/appliance/pkg/executer"
Expand Down
2 changes: 1 addition & 1 deletion pkg/syslinux/syslinux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"fmt"
"testing"

"github.com/golang/mock/gomock"
"go.uber.org/mock/gomock"
. "github.com/onsi/ginkgo/v2/dsl/core"
. "github.com/onsi/gomega"
"github.com/openshift/appliance/pkg/executer"
Expand Down