stackrox(ci): finish ocp 4-20 testing setup #71132

davdhacs · 2025-11-06T23:32:40Z

Enable OCP 4.20 tests on master as always-run/run-if-changed
Remove OCP 4.18 and 4.19 test configs

davdhacs · 2025-11-07T00:44:18Z

/pj-rehearse

openshift-ci-robot · 2025-11-07T00:44:21Z

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

davdhacs · 2025-11-07T03:40:16Z

/pj-rehearse

openshift-ci-robot · 2025-11-07T03:40:19Z

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

davdhacs · 2025-11-07T04:18:48Z

/cc @tommartensen @msugakov @BradLugo
/unhold

msugakov · 2025-11-07T08:08:42Z

ci-operator/config/stackrox/stackrox/stackrox-stackrox-master__ocp-4-18.yaml

    workflow: stackrox-automation-flavors-ocp-4-e2e
  timeout: 5h0m0s
- always_run: true
+- always_run: false


Why do we need 4.18 on master at all?
Should we just delete it as well as 4.19 after making 4.20 the default for tests?

Keeping it (as only run on-demand) allows us to run CI tests against a supported version of OCP from a PR.
I think it would be useful to keep the range of OCP versions available to test while we're supporting running on them. What do you think? I think the downsides are A: the extra files in this directory (too many / confusing for the wider team to approach the config?) and B: the long /test ? list (but that is already un-usably long with only the oldest+latest versions).

Yes, /test ? goes out of hand and that's the main reason for me. Whenever I ask Konflux to /retest <something>, OSCI replies with longer and longer list.

Also, we don't cover all versions so this looks inconsistent and as an engineer not involved in OSCI I would doubt before attempting anything on 4.18.

Finally, these files add mental overhead which means more expensive maintenance.

If I have a case to test my change on older OCP version, I'd spin up an Infra cluster and test my change there, without e2e tests. In addition, will trust e2e tests on the "newest" and the "oldest" versions to do their part and provide safety from regressions.

Therefore, if there's no active/persistent situation to use them, I'd vote to delete instead of having them "in case of need" because the need may never materialize.

as an engineer not involved in OSCI I would doubt before attempting anything on 4.18.

Finally, these files add mental overhead which means more expensive maintenance.

I think these are reason enough to remove the extra version tests.

will trust e2e tests on the "newest" and the "oldest" versions to do their part and provide safety from regressions.

👍

msugakov

/lgtm

but

/hold

due to the question

msugakov · 2025-11-10T10:02:14Z

ci-operator/jobs/infra-periodics.yaml

    serviceAccountName: upgrader
 - agent: kubernetes
-  cluster: build07
+  cluster: app.ci


Is this cluster: build07 -> cluster: app.ci change intended and/or automatic? Asking because I never saw app.ci before.

This was automatic. I'll investigate.

It was resolved in master: https://github.com/openshift/release/pull/71166/files

openshift-ci-robot · 2025-11-12T18:19:17Z

[REHEARSALNOTIFIER]
@davdhacs: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-stackrox-stackrox-master-ocp-4-20-nongroovy-e2e-tests	stackrox/stackrox	presubmit	Presubmit changed
pull-ci-stackrox-stackrox-master-ocp-4-20-compliance-e2e-tests	stackrox/stackrox	presubmit	Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-4-20-operator-e2e-tests	stackrox/stackrox	presubmit	Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-4-20-qa-e2e-tests	stackrox/stackrox	presubmit	Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-4-20-scanner-v4-install-tests	stackrox/stackrox	presubmit	Ci-operator config changed
pull-ci-stackrox-stackrox-master-ocp-4-20-ui-e2e-tests	stackrox/stackrox	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci · 2025-11-12T18:33:36Z

@davdhacs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

msugakov

/lgtm
/unhold

Thank you!

openshift-ci · 2025-11-13T10:20:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davdhacs, msugakov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~ci-operator/config/stackrox/OWNERS~~ [davdhacs,msugakov]
~~ci-operator/jobs/stackrox/stackrox/OWNERS~~ [davdhacs,msugakov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

davdhacs · 2025-11-13T13:36:22Z

/pj-rehearse ack

openshift-ci-robot · 2025-11-13T13:36:25Z

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

davdhacs added 4 commits September 2, 2025 11:43

stackrox: disable autorun on nongroovy on ocp4.18

c52d297

Merge branch 'master' into missed-nongroovy-418-autorun

5a4922e

make update

96e012b

alwaysrun ocp420

7f29507

openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 6, 2025

davdhacs added 3 commits November 6, 2025 16:43

disable 4.19 autorun

48f04d6

Merge branch 'missed-nongroovy-418-autorun' into rox-ocp-4-20-finish

59c9a08

make update

211408b

make update

1b92582

openshift-ci bot requested review from BradLugo, msugakov and tommartensen November 7, 2025 04:18

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2025

msugakov reviewed Nov 7, 2025

View reviewed changes

remove in-between versions

88c8ebe

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2025

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 7, 2025

Merge branch 'master' into rox-ocp-4-20-finish

396cd83

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2025

openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 7, 2025

davdhacs added 2 commits November 7, 2025 13:26

make update

31863dd

make update

1a225ee

openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2025

davdhacs requested a review from msugakov November 7, 2025 21:11

msugakov approved these changes Nov 10, 2025

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 10, 2025

openshift-ci bot assigned msugakov Nov 10, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2025

Merge branch 'master' into rox-ocp-4-20-finish

9abc4d3

openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Nov 12, 2025

davdhacs requested a review from msugakov November 12, 2025 21:17

msugakov approved these changes Nov 13, 2025

View reviewed changes

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 13, 2025

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 13, 2025

openshift-merge-bot bot merged commit 9c83e72 into openshift:master Nov 13, 2025
16 checks passed

stackrox(ci): finish ocp 4-20 testing setup #71132

stackrox(ci): finish ocp 4-20 testing setup #71132

Uh oh!

Conversation

davdhacs commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davdhacs commented Nov 7, 2025

Uh oh!

openshift-ci-robot commented Nov 7, 2025

Uh oh!

davdhacs commented Nov 7, 2025

Uh oh!

openshift-ci-robot commented Nov 7, 2025

Uh oh!

davdhacs commented Nov 7, 2025

Uh oh!

msugakov Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

davdhacs Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

msugakov Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davdhacs Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

msugakov left a comment

Choose a reason for hiding this comment

Uh oh!

msugakov Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

davdhacs Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

davdhacs Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Nov 12, 2025

Uh oh!

openshift-ci bot commented Nov 12, 2025

Uh oh!

msugakov left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 13, 2025

Uh oh!

davdhacs commented Nov 13, 2025

Uh oh!

openshift-ci-robot commented Nov 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

davdhacs commented Nov 6, 2025 •

edited

Loading

msugakov Nov 7, 2025 •

edited

Loading