-
Notifications
You must be signed in to change notification settings - Fork 2k
stackrox(ci): finish ocp 4-20 testing setup #71132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-bot
merged 13 commits into
openshift:master
from
stackrox:rox-ocp-4-20-finish
Nov 13, 2025
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c52d297
stackrox: disable autorun on nongroovy on ocp4.18
davdhacs 5a4922e
Merge branch 'master' into missed-nongroovy-418-autorun
davdhacs 96e012b
make update
davdhacs 7f29507
alwaysrun ocp420
davdhacs 48f04d6
disable 4.19 autorun
davdhacs 59c9a08
Merge branch 'missed-nongroovy-418-autorun' into rox-ocp-4-20-finish
davdhacs 211408b
make update
davdhacs 1b92582
make update
davdhacs 88c8ebe
remove in-between versions
davdhacs 396cd83
Merge branch 'master' into rox-ocp-4-20-finish
davdhacs 31863dd
make update
davdhacs 1a225ee
make update
davdhacs 9abc4d3
Merge branch 'master' into rox-ocp-4-20-finish
davdhacs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need 4.18 on
masterat all?Should we just delete it as well as 4.19 after making 4.20 the default for tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping it (as only run on-demand) allows us to run CI tests against a supported version of OCP from a PR.
I think it would be useful to keep the range of OCP versions available to test while we're supporting running on them. What do you think? I think the downsides are A: the extra files in this directory (too many / confusing for the wider team to approach the config?) and B: the long
/test ?list (but that is already un-usably long with only the oldest+latest versions).Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes,
/test ?goes out of hand and that's the main reason for me. Whenever I ask Konflux to/retest <something>, OSCI replies with longer and longer list.Also, we don't cover all versions so this looks inconsistent and as an engineer not involved in OSCI I would doubt before attempting anything on 4.18.
Finally, these files add mental overhead which means more expensive maintenance.
If I have a case to test my change on older OCP version, I'd spin up an Infra cluster and test my change there, without e2e tests. In addition, will trust e2e tests on the "newest" and the "oldest" versions to do their part and provide safety from regressions.
Therefore, if there's no active/persistent situation to use them, I'd vote to delete instead of having them "in case of need" because the need may never materialize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are reason enough to remove the extra version tests.
👍