refactor(language_server): split options for linting and formatting #13627

Sysix · 2025-09-09T18:08:46Z

Splits the options intern, so we can define options for ServerLinter and ServerFormatter.
There is no option added. This comes later (maybe experimental: bool?)

Sysix · 2025-09-09T18:09:06Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-09-09T18:20:43Z

CodSpeed Instrumentation Performance Report

Merging #13627 will not alter performance

_{Comparing 09-09-chore_language_server_split_options_for_linting_and_formatting (137896a) with main (8659498)¹}

Summary

✅ 37 untouched

No successful run was found on main (137896a) during the generation of this report, so 8659498 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copilot

Pull Request Overview

This PR refactors the options structure in the language server to separate linting and formatting concerns. The main Options struct now contains dedicated LintOptions and FormatOptions fields, allowing for cleaner separation between linter and formatter configurations.

Split the monolithic Options struct into specialized LintOptions and FormatOptions
Moved linting-specific types and logic to a dedicated linter::options module
Updated all references to use the new nested structure (options.lint.*)

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`crates/oxc_language_server/src/options.rs`	Restructured to use flattened `LintOptions` and `FormatOptions` fields
`crates/oxc_language_server/src/linter/options.rs`	New module containing all linting-specific options and logic
`crates/oxc_language_server/src/formatter/options.rs`	New module with placeholder `FormatOptions` struct
`crates/oxc_language_server/src/worker.rs`	Updated to access linting options via `options.lint`
`crates/oxc_language_server/src/linter/server_linter.rs`	Updated imports and function signatures to use `LintOptions`
`crates/oxc_language_server/src/tester.rs`	Modified to construct `Options` with nested `LintOptions`

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_language_server/src/linter/options.rs

camc314 · 2025-09-16T01:16:40Z

Merge activity

Sep 16, 1:16 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 16, 1:16 AM UTC: camc314 added this pull request to the Graphite merge queue.
Sep 16, 1:21 AM UTC: Merged by the Graphite merge queue.

…13627) Splits the options intern, so we can define options for `ServerLinter` and `ServerFormatter`. There is no option added. This comes later (maybe `experimental: bool`?)

## [1.16.0] - 2025-09-16 ### 🚀 Features - 97c8d06 linter: Add `preserve-caught-error` rule (#13748) (孔辉) - 8c19b18 linter/exhaustive-deps: Implement fixer for dep in global scope (#13783) (camc314) - 06bce8f linter/exhaustive-deps: Implement fixer for missing dep (#13782) (camc314) - a8675f4 linter: Add eslint/class-methods-use-this rule (#12977) (Peter Cardenas) - db33196 parser: Adds typescript rule for empty argument list (#13730) (Karan Kiri) - 2751193 linter: Add `eslint/no-useless-computed-key` rule (#13428) (yefan) - 9a205d1 regex-parser: Parse simple `TemplateLiterals` (#13265) (Sysix) ### 🐛 Bug Fixes - a2c91cd linter: Drop `rules` to allow mutable access to `ctx_host` in `run_external_rules` (#13832) (camc314) - 3af1e5d linter/no-unsafe-declaration-merging: Always mark first span as primary (#13830) (camc314) - 1c43c7c linter: Keep message when merging composite fixes (#13827) (camc314) - 26af302 linter/exhaustive-deps: Check stable value is on lhs of assignment expr (#13815) (camc314) - 4bc12d0 linter/exhaustive-deps: Remove impossible comparison with parent kind (#13814) (camc314) - 12baf5e linter/exhaustive-deps: Respect primary span when identifying disable directive location (#13781) (camc314) - fa7400a linter/no-undef: False positive with `arguments` in functions (#13763) (camc314) - 50e6e3c editor: Restrict servers paths for `oxc.path.server` (#13740) (Sysix) - b45077d editor: Strip leading slash for bin path on windows (#13738) (Sysix) - 8fa6227 editor: Don't allow `oxc.path.server` for untrusted workspaces (#13734) (Sysix) - 56da114 linter/react/jsx-handler-names: Do not detect the function name within the inline-function's body block (#13456) (Takuji Shimokawa) - b2bc5b4 linter/react-perf/jsx-no-new-object-as-prop: Skip as/satisfies exprs (#13718) (camc314) - ab51394 raw_transfer: Disable layout assertions on some 32-bit platforms (#13716) (overlookmotel) - 09428f6 linter/plugins: Remove outdated comment (#13691) (overlookmotel) - a294721 linter/plugins: Exit early if JS plugins enabled on unsupported platforms (#13689) (overlookmotel) - 68a2280 linter/plugins: More graceful exit for `--experimental-js-plugins` CLI option (#13688) (overlookmotel) ### 🚜 Refactor - 395d40d linter: Derive inmpls for `PartialEq`, `Eq` over manual ones (#13828) (camc314) - 8e4cd8f linter/func-names: Use `run_once` over looping over all nodes (#13798) (camc314) - 7f4e2fe eslint/func-names: Clean up implementation and improve documentation (#13601) (Antoine Zanardi) - 137896a language_server: Split options for linting and formatting (#13627) (Sysix) - 7346099 linter: Move `oxlint` application code into separate module (#13745) (overlookmotel) - 6dd4107 linter: Remove `#[cfg(test)]` attributes from `tester` module (#13714) (overlookmotel) - c40c6ef linter/plugins: Directory for JS plugins-related code (#13701) (overlookmotel) - a0022c1 linter/plugins: Improve error messages for JS plugins (#13699) (overlookmotel) - 1fd993f napi/oxlint: Rename `napi/oxlint2` to `napi/oxlint` (#13682) (overlookmotel) ### ⚡ Performance - 90c8286 linter: Detect node types from `let..else` statements (#13690) (camchenry) - 08c05df semantic: Make CFG construction a compile-time feature (#13678) (Boshen) ### 🎨 Styling - 99a7638 linter: Add comments + re-organise imports (#13715) (overlookmotel) ### 🧪 Testing - 18a1145 linter: Add debug assertions for skipping rules (#13724) (camc314) - cb080de linter/no-unused-vars: Add test for non ASCII chars in JSX components (#13820) (camc314) - b6eba27 linter/no-undef: Add more test cases for `arguments` (#13764) (camc314) - fb2d087 linter: Set CWD for tests (#13722) (overlookmotel) Co-authored-by: camc314 <[email protected]>

github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 9, 2025

This was referenced Sep 9, 2025

feat(regex-parser): parse simple TemplateLiterals #13265

Merged

feat(linter): add eslint/no-misleading-character-class #13365

Merged

Sysix mentioned this pull request Sep 9, 2025

fix(linter): don't panic when parsing regex with multiple parentheses #13524

Merged

Sysix changed the base branch from 08-22-feat_linter_add_eslint_no-misleading-character-class_ to graphite-base/13627 September 9, 2025 18:10

Sysix force-pushed the graphite-base/13627 branch from b4d46df to 78a1146 Compare September 9, 2025 18:10

Sysix force-pushed the 09-09-chore_language_server_split_options_for_linting_and_formatting branch from b23db0a to 097e4b4 Compare September 9, 2025 18:10

Sysix changed the base branch from graphite-base/13627 to main September 9, 2025 18:10

Sysix force-pushed the 09-09-chore_language_server_split_options_for_linting_and_formatting branch 3 times, most recently from e1fe3b5 to ce97ea7 Compare September 11, 2025 18:26

Sysix mentioned this pull request Sep 11, 2025

feat(language_server): introduce ServerFormatter #13700

Merged

Sysix force-pushed the 09-09-chore_language_server_split_options_for_linting_and_formatting branch 3 times, most recently from 3798dad to 23313c4 Compare September 12, 2025 17:16

Sysix mentioned this pull request Sep 12, 2025

refactor(language_server): introduce LSPFileSystem #13731

Merged

Sysix changed the title ~~chore(language_server): split options for linting and formatting~~ refactor(language_server): split options for linting and formatting Sep 12, 2025

Sysix force-pushed the 09-09-chore_language_server_split_options_for_linting_and_formatting branch 2 times, most recently from 389b108 to f70cdae Compare September 15, 2025 18:54

Sysix marked this pull request as ready for review September 15, 2025 19:05

Sysix requested a review from camc314 as a code owner September 15, 2025 19:05

Copilot AI review requested due to automatic review settings September 15, 2025 19:05

Copilot AI reviewed Sep 15, 2025

View reviewed changes

crates/oxc_language_server/src/linter/options.rs Outdated Show resolved Hide resolved

crates/oxc_language_server/src/linter/options.rs Outdated Show resolved Hide resolved

Sysix force-pushed the 09-09-chore_language_server_split_options_for_linting_and_formatting branch from f70cdae to e2e7901 Compare September 15, 2025 19:19

camc314 approved these changes Sep 16, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 16, 2025

refactor(language_server): split options for linting and formatting (#…

137896a

…13627) Splits the options intern, so we can define options for `ServerLinter` and `ServerFormatter`. There is no option added. This comes later (maybe `experimental: bool`?)

graphite-app bot force-pushed the 09-09-chore_language_server_split_options_for_linting_and_formatting branch from e2e7901 to 137896a Compare September 16, 2025 01:17

graphite-app bot merged commit 137896a into main Sep 16, 2025
26 checks passed

graphite-app bot deleted the 09-09-chore_language_server_split_options_for_linting_and_formatting branch September 16, 2025 01:21

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 16, 2025

This was referenced Sep 16, 2025

release(oxlint): v1.16.0 #13831

Closed

release(oxlint): v1.16.0 #13833

Merged

This was referenced Sep 19, 2025

feat(editor): add oxc.fmt.experimental flag #13923

Merged

refactor(langauge_server): move Backend into own file #13955

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(language_server): split options for linting and formatting #13627

refactor(language_server): split options for linting and formatting #13627

Uh oh!

Sysix commented Sep 9, 2025 •

edited

Loading

Uh oh!

Sysix commented Sep 9, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Sep 9, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

camc314 commented Sep 16, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

refactor(language_server): split options for linting and formatting #13627

refactor(language_server): split options for linting and formatting #13627

Uh oh!

Conversation

Sysix commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #13627 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

camc314 commented Sep 16, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Uh oh!

Sysix commented Sep 9, 2025 •

edited

Loading

Sysix commented Sep 9, 2025 •

edited

Loading

codspeed-hq bot commented Sep 9, 2025 •

edited

Loading

camc314 commented Sep 16, 2025 •

edited by graphite-app bot

Loading