feat(regex-parser): parse simple TemplateLiterals

[Sysix]

This PR adds the function to parse TemplateLiterals.
If the new RegExp(${variable}) or new RegExp("", ${foo}) the parsing will be skipped, this is a different behavior then for StringLiterals.
https://github.com/eslint/eslint/blob/5082fc206de6946d9d4c20e57301f78839b3b9f2/tests/lib/rules/no-misleading-character-class.js#L91-L93
I would like to have a strict algo, when a regexp will be parsed and not. Currently, every rule does it by its own.

oxc/crates/oxc_linter/src/rules/eslint/no_control_regex.rs

Line 322 in 2cd4c7b

r"new RegExp('\\u{1F}', flags)", // unknown flags, we assume no 'u'

Moved some structs into the parent directory, so it can be consumed by both parsers. I guess ParserTrait could be helpful to share common methods like

• consume_hex_digits
• parse_unicode_escape_sequence

[Sysix]

• feat(linter): add eslint/no-misleading-character-class #13365
• feat(regex-parser): parse simple TemplateLiterals #13265 👈 (View in Graphite)
• fix(linter): don't panic when parsing regex with multiple parentheses #13524
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #13265 will not alter performance

_{Comparing 08-22-fix_regex-parser_parse_simple_templateliterals_ (9a205d1) with main (08c05df)¹}

Summary

✅ 37 untouched

Footnotes

1. No successful run was found on main (9a205d1) during the generation of this report, so 08c05df was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Copilot]

Pull Request Overview

This PR implements parsing of simple template literals in the regex parser, extending support beyond string literals to include template literals like new RegExp(\pattern`)`. The implementation skips parsing when template literals contain expressions/substitutions.

• Adds a new template_literal_parser module with full template literal parsing capability
• Refactors shared code (AST types, options, characters) to be accessible by both string and template literal parsers
• Updates regex utility functions to handle template literal arguments in RegExp constructors

Reviewed Changes

Copilot reviewed 15 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
crates/oxc_regular_expression/src/parser/reader/template_literal_parser/parser_impl.rs	Core template literal parser implementation with escape sequence handling
crates/oxc_regular_expression/src/parser/reader/template_literal_parser/mod.rs	Module definition and comprehensive test cases
crates/oxc_regular_expression/src/parser/reader/template_literal_parser/diagnostics.rs	Error diagnostics specific to template literal parsing
crates/oxc_regular_expression/src/parser/reader/template_literal_parser/ast.rs	AST structure for template literals
crates/oxc_regular_expression/src/parser/reader/reader_impl.rs	Updated reader to detect and parse template literals
crates/oxc_regular_expression/src/parser/reader/mod.rs	Module restructuring to expose shared components
crates/oxc_regular_expression/src/parser/reader/ast.rs	Shared CodePoint AST structure moved from string parser
crates/oxc_linter/src/utils/regex.rs	Enhanced regex utilities to handle template literal arguments

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[camc314]

@Sysix somehow this has ended up with conflicts 🫠

[leaysgur]

Sorry for the slow response! 🙇🏻

I try to review by Saturday(during the flight), or at the latest by next Tuesday.

[Sysix]

No need to rush, glad you're offering your help with the regex parser

[leaysgur]

@Sysix Sorry for the delay!

As you noticed, there is still room for reducing duplicate lines, but I think we can address that at another time.

[leaysgur]

@Sysix LGTM 👏🏻

@camc314
I've finished reviewing the regex parser part(oxc_regular_expression/*).
Would you please review the usage part(oxc_linter/*) and merge after that?

[camc314]

Merge activity

• Sep 11, 8:52 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Sep 11, 11:09 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Sep 11, 11:15 PM UTC: Merged by the Graphite merge queue.

[Sysix]

@leaysgur thanks you, your approval is needed 🫶

[leaysgur]

🚀