-
-
Notifications
You must be signed in to change notification settings - Fork 269
re-enable flow scanner #6262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
re-enable flow scanner #6262
Conversation
You mention above that you worked on publishing v5.8 (up from some v4.3x something), but I only see 5.1.0 in a repo, and 5.2.0 in another. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple things, and you might know more on the nature of the changes needed. Most of the work only needs to be done in the descriptor file, the rest is generated from there
@echoix Thank you so much for your prompt reply and support. I would like to clarify: Version 5.2 was the latest on NPM before being unpublished due to an RCE vulnerability, as explained in the core package. The original Lightning Flow Scanner SFDX repo has been relocated, previous references still work and functionality for MegaLinter remains unaffected. The NPM package is now patched and scoped under the NPM organization flow-scanner, but published by me personally(user rhalman). The new version is 1.5.0 at www.npmjs.com/package/@flow-scanner/lightning-flow-scanner-cli Based on your feedback, I tried to keep the current naming intact and decided to only update the install scripts and documentation. Could you advise on the steps needed to test the scope and naming changes correctly? |
@nvuillam Hi Nicolas, I hope all is well. I'd really appreciate your consideration of the RCE vulnerability, and the rescoped package once you can find some time. |
Hi @nvuillam and @llaville ,
First off, I'd really love the opportunity to contribute to MegaLinter, but its turning out to be a bit of a challenge for me!
After deprecating parts of the Lightning Flow Scanner Org and unpublishing the original sfdx version on NPM, I have continued to deliver v5.8, a more secure version. Id love to integrate this more robust version in Mega Linter, as the functionality remains the same. Thank you for your consideration and support.
Note
Replaces deprecated lightning-flow-scanner with lightning-flow-scanner-cli, re-enables it across build, descriptors, flavors, tests, and docs with updated versioning and metadata.
lightning-flow-scanner
withlightning-flow-scanner-cli
and re-enable the linter.Dockerfile
and the linter Dockerfile; introduceLIGHTNING_FLOW_SCANNER_VERSION=5.8.0
.salesforce.megalinter-descriptor.yml
(name, URLs, version regex, install snippets, VS Code link) and remove disabled status.SALESFORCE_LIGHTNING_FLOW_SCANNER
toflavors/salesforce/flavor.json
andmegalinter/descriptors/all_flavors.json
.salesforce_lightning_flow_scanner
inlinters_matrix.json
.mkdocs.yml
nav entry tolightning-flow-scanner-cli
and path.lightning-flow-scanner-cli
.linter-helps.json
,linter-licenses.json
,linter-links-previews.json
,linter-versions.json
) tolightning-flow-scanner-cli
with updated titles/info.Written by Cursor Bugbot for commit 8012a3f. This will update automatically on new commits. Configure here.