Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .automation/generated/linter-links-previews.json
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,9 @@
"title": "instrumenta/kubeval"
},
"lightning-flow-scanner": {
"description": "Lightning-Flow-Scanner has 5 repositories available. Follow their code on GitHub.",
"description": "A Salesforce CLI Plugin designed to proactively enforce secure and maintainable Salesforce Flows. It detects unsafe running contexts, hardcoded IDs, unhandled nulls, inefficient database operations and more, helping teams ensure their automations are safe and reliable..",
"image": "https://avatars.githubusercontent.com/u/148573214?s=280&v=4",
"title": "Lightning-Flow-Scanner"
"title": "Flow-Scanner"
},
"lintr": {
"description": "Static Code Analysis for R. Contribute to r-lib/lintr development by creating an account on GitHub.",
Expand Down
2 changes: 1 addition & 1 deletion .automation/generated/linter-versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"kubeconform": "0.7.0",
"kubescape": "3.0.41",
"kubeval": "0.16.1",
"lightning-flow-scanner": "3.29.0",
"lightning-flow-scanner-cli": "3.29.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Version Mismatch in Tool Configuration

The linter-versions.json file lists lightning-flow-scanner-cli at version 3.29.0, but the Dockerfile, documentation, and other installation sources reference version 1.4.0. This inconsistency can cause the wrong tool version to be installed or used.

Fix in Cursor Fix in Web

"lintr": "0.0.0",
"ls-lint": "2.3.1",
"luacheck": "1.2.0",
Expand Down
1 change: 1 addition & 0 deletions .automation/generated/linters_matrix.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@
"salesforce_sfdx_scanner_apex",
"salesforce_sfdx_scanner_aura",
"salesforce_sfdx_scanner_lwc",
"salesforce_lightning_flow_scanner",
"scala_scalafix",
"snakemake_lint",
"snakemake_snakefmt",
Expand Down
9 changes: 9 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,8 @@ ARG GEM_RUBOCOP_RAKE_VERSION=0.7.1
ARG GEM_RUBOCOP_RSPEC_VERSION=3.7.0
# renovate: datasource=npm depName=@salesforce/sfdx-scanner
ARG SALESFORCE_SFDX_SCANNER_VERSION=4.12.0
# renovate: datasource=npm depName=lightning-flow-scanner
ARG LIGHTNING_FLOW_SCANNER_VERSION=5.6.2
# renovate: datasource=pypi depName=snakemake
ARG PIP_SNAKEMAKE_VERSION=9.11.6
# renovate: datasource=pypi depName=snakefmt
Expand Down Expand Up @@ -1111,6 +1113,13 @@ RUN curl -sSfL https://raw.githubusercontent.com/anchore/syft/refs/tags/v${REPOS
# RUN sf plugins install @salesforce/sfdx-scanner@${SALESFORCE_SFDX_SCANNER_VERSION} \
# && (npm cache clean --force || true) \
# && rm -rf /root/.npm/_cacache
#
# lightning-flow-scanner installation

&& echo y|sf plugins install lightning-flow-scanner@${LIGHTNING_FLOW_SCANNER_VERSION} \
&& (npm cache clean --force || true) \
&& rm -rf /root/.npm/_cacache \

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dockerfile Syntax Error in Installation Commands

The lightning-flow-scanner installation commands are malformed. They begin with && without a preceding RUN instruction, and a trailing backslash on line 1121 is followed by an empty line. This creates invalid Dockerfile syntax and causes the Docker build to fail.

Fix in Cursor Fix in Web

#
# scalafix installation
&& ./coursier install scalafix --quiet --install-dir /usr/bin && rm -rf /root/.cache \
Expand Down
70 changes: 34 additions & 36 deletions docs/descriptors/salesforce_lightning_flow_scanner.md

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions flavors/salesforce/flavor.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"SALESFORCE_SFDX_SCANNER_APEX",
"SALESFORCE_SFDX_SCANNER_AURA",
"SALESFORCE_SFDX_SCANNER_LWC",
"SALESFORCE_LIGHTNING_FLOW_SCANNER",
"SNAKEMAKE_LINT",
"SNAKEMAKE_SNAKEFMT",
"SPELL_CSPELL",
Expand Down
2 changes: 1 addition & 1 deletion linters/salesforce_lightning_flow_scanner/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ ARG NPM_SALESFORCE_PLUGIN_PACKAGING_VERSION=2.20.5
# renovate: datasource=npm depName=sfdx-hardis
ARG SFDX_HARDIS_VERSION=6.5.4
# renovate: datasource=npm depName=lightning-flow-scanner
ARG LIGHTNING_FLOW_SCANNER_VERSION=5.2.0
ARG LIGHTNING_FLOW_SCANNER_VERSION=5.6.2
#ARG__END

####################
Expand Down
1 change: 1 addition & 0 deletions megalinter/descriptors/all_flavors.json
Original file line number Diff line number Diff line change
Expand Up @@ -935,6 +935,7 @@
"SALESFORCE_SFDX_SCANNER_APEX",
"SALESFORCE_SFDX_SCANNER_AURA",
"SALESFORCE_SFDX_SCANNER_LWC",
"SALESFORCE_LIGHTNING_FLOW_SCANNER",
"SNAKEMAKE_LINT",
"SNAKEMAKE_SNAKEFMT",
"SPELL_CSPELL",
Expand Down
12 changes: 5 additions & 7 deletions megalinter/descriptors/salesforce.megalinter-descriptor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,9 @@ linters:

# Lightning Flow Scanner
- linter_name: lightning-flow-scanner
disabled: true
disabled_reason: Repo archived -> https://github.com/Lightning-Flow-Scanner
files_sub_directory: force-app
linter_text: |
**Lightning Flow Scanner** is a specialized SFDX plugin that analyzes Salesforce Flows for integrity issues, performance problems, and adherence to best practices. It helps developers build reliable and maintainable Flow automations.
**Lightning Flow Scanner** A Salesforce CLI Plugin designed to proactively enforce secure and maintainable Salesforce Flows. It detects unsafe running contexts, hardcoded IDs, unhandled nulls, inefficient database operations and more, helping teams ensure their automations are safe and reliable.

**Key Features:**

Expand All @@ -286,10 +284,10 @@ linters:
- **SFDX Native**: Built as a native SFDX plugin for consistent Salesforce toolchain integration

If your root folder is not **force-app**, please set variable SALESFORCE_LIGHTNING_FLOW_SCANNER_DIRECTORY
linter_url: https://github.com/Lightning-Flow-Scanner
linter_url: https://flow-scanner.github.io/lightning-flow-scanner-cli/
linter_repo: https://github.com/Lightning-Flow-Scanner/lightning-flow-scanner-sfdx
linter_rules_url: https://github.com/Lightning-Flow-Scanner/lightning-flow-scanner-core#rules
linter_banner_image_url: https://raw.githubusercontent.com/Lightning-Flow-Scanner/.github/main/docs/images/bannerslim.png
linter_banner_image_url: https://raw.githubusercontent.com/Flow-Scanner/lightning-flow-scanner-cli/main/docs/images/banner.png
linter_rules_configuration_url: https://github.com/Lightning-Flow-Scanner/lightning-flow-scanner-sfdx#configuration
linter_spdx_license: AGPL-3.0
config_file_name: .flow-scanner.json
Expand All @@ -313,12 +311,12 @@ linters:
dockerfile:
- |-
# renovate: datasource=npm depName=lightning-flow-scanner
ARG LIGHTNING_FLOW_SCANNER_VERSION=5.2.0
ARG LIGHTNING_FLOW_SCANNER_VERSION=5.6.2
- |-
RUN echo y|sf plugins install lightning-flow-scanner@${LIGHTNING_FLOW_SCANNER_VERSION} \
&& (npm cache clean --force || true) \
&& rm -rf /root/.npm/_cacache
ide:
vscode:
- name: Lightning Flow Scanner
url: https://marketplace.visualstudio.com/items?itemName=ForceConfigControl.lightningflowscanner
url: https://marketplace.visualstudio.com/items?itemName=ForceConfigControl.lightning-flow-scanner-vsx