Skip to content

Conversation

txssu
Copy link
Contributor

@txssu txssu commented Jun 27, 2025

Before

image

After

image

@SteffenDE SteffenDE merged commit 273cc31 into phoenixframework:main Jun 27, 2025
@SteffenDE
Copy link
Contributor

Thank you!

@txssu txssu deleted the fix-missing-examples branch June 28, 2025 21:01
@rhcarvalho
Copy link
Contributor

This is strange, I would think the documentation NPM package would support the language hint in Markdown code blocks, just as in the example here:

https://github.com/documentationjs/documentation/blob/8d029e735d2661c8f5e097c285050c7abe5edf6e/docs/NODE_API.md#examples

However, there's indeed a bug which describes exactly what we observed here documentationjs/documentation#1428.

And I confirmed that the code blocks go missing if we set the language to javascript (or anything else).

@SteffenDE
Copy link
Contributor

@rhcarvalho some time I might be able to finish up #6364, then we'll have more modern docs :D

@rhcarvalho
Copy link
Contributor

Wow, massive change! The UI looks the same, so perhaps the bug in only manifesting when the source code is JS, not TS?!

Would be nice to have the JS docs surfaced inside of the Elixir docs, single experience! But that might require yet another massive lift.

Hey, thanks for the good work in Phoenix! Upgrading to 1.8 and LV 1.1 was smooth (other than self-inflicted small mistakes on my side, promptly fixed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants