(PA-7608) Update artifactory URLs for puppetcore nightlies

[skyamgarp]

No description provided.

[joshcooper]

@skyamgarp one git process thing, in cases where you want to revert something and take a different path, it's better to git revert c3bc4959a1a3246d198c622f2bbb2e6aaf619087 and then add your new changes in a different commit. That way it's clear the old behavior was reverted. If you combine the revert with new code, it's not always clear if everything was reverted or just partially.

Could you add puppetcore8-nightly support to the windows task too? See

puppetlabs-puppet_agent/tasks/install_powershell.ps1

Lines 119 to 127 in 0d52b3d

	if (($collection -like '*nightly*') -And -Not ($PSBoundParameters.ContainsKey('windows_source'))) {
	$windows_source = 'https://nightlies.puppet.com/downloads'
	} elseif (($collection -like '*puppetcore*') -And -Not ($PSBoundParameters.ContainsKey('windows_source'))) {
	$windows_source = 'https://artifacts-puppetcore.puppet.com/v1/download'
	}
	if ($absolute_source) {
	$msi_source = "$absolute_source"
	} elseif ($collection -like '*puppetcore*') {

Also could you add puppetcore8-nightly to the task metadata for the bash and powershell tasks

puppetlabs-puppet_agent/tasks/install_shell.json

Line 12 in 0d52b3d

"type": "Optional[Enum[puppet7, puppet8, puppet, puppet7-nightly, puppet8-nightly, puppet-nightly, puppetcore7, puppetcore8]]"

puppetlabs-puppet_agent/tasks/install_powershell.json

Line 11 in 0d52b3d

"type": "Optional[Enum[puppet7, puppet8, puppet, puppet7-nightly, puppet8-nightly, puppet-nightly]]"

It looks like I forgot to add puppetcore7 and puppetcore8 to the latter. Could you add those too?

[joshcooper]

LGTM, could you make sure to test these different combinations (if you haven't already)?

[skyamgarp]

LGTM, could you make sure to test these different combinations (if you haven't already)?

I have tested both nightlies options. It works. But was not able to test puppetcore8 as requires password and doesn't accept the password param as collection.

[gavindidrichsen]

LGTM