Skip to content

(CAT-2207) Remove legacy facts #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amitkarsale wants to merge 1 commit into from
Closed

(CAT-2207) Remove legacy facts #191

amitkarsale wants to merge 1 commit into from

Conversation

@amitkarsale
Copy link
Contributor

@amitkarsale amitkarsale commented Jan 28, 2025

Removed legacy facts from the task

@amitkarsale amitkarsale requested a review from a team as a code owner January 28, 2025 12:14
MartyEwings
MartyEwings previously requested changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fact change looks good, i wouldnt update the hiera labels

@MartyEwings MartyEwings added the enhancement New feature or request label Jan 28, 2025
@MartyEwings
Copy link
Collaborator

MartyEwings commented Jan 28, 2025

Unit testing failing due to a gem dep issue, will need resolved before merging and release

@amitkarsale amitkarsale force-pushed the CAT-2207 branch 12 times, most recently from cee1520 to 02e5f13 Compare January 29, 2025 10:05
@amitkarsale
Copy link
Contributor Author

amitkarsale commented Jan 29, 2025

Unit testing failing due to a gem dep issue, will need resolved before merging and release

The dependency check failure seems irrelevant.. 🤔

@MartyEwings
Copy link
Collaborator

MartyEwings commented Jan 29, 2025

Unit testing failing due to a gem dep issue, will need resolved before merging and release

The dependency check failure seems irrelevant.. 🤔

Yeah its unrelated, but i want to get the CI pipline working before making any merges, i know how to fix ill need a few days to get around to it

@MartyEwings MartyEwings self-requested a review January 31, 2025 11:26
@MartyEwings
Copy link
Collaborator

MartyEwings commented Jan 31, 2025

@amitkarsale can you rebase over main to pick up the CI updates

@MartyEwings MartyEwings dismissed their stale review January 31, 2025 11:30

Has been resolved

MartyEwings
MartyEwings approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@MartyEwings MartyEwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will merge when rebase has been completed, assuming all CI passes

@amitkarsale amitkarsale closed this Feb 3, 2025
@amitkarsale
Copy link
Contributor Author

amitkarsale commented Feb 3, 2025

The changes are being addressed in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartyEwings MartyEwings MartyEwings approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amitkarsale @MartyEwings