chore: Adds some missing type annotations #2396
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schuylermartin45
had a problem deploying
to
ack
GitHub Actions
Failure
|
Label error. Requires exactly 1 of: breaking, build, chore, ci, docs, feat, fix, perf, refactor, style, test. Found: . Follow https://www.conventionalcommits.org to get auto-labeling to work correctly. |
schuylermartin45
force-pushed
the
main
branch
from
f54c1c0 to
a0ee525
Compare
schuylermartin45
had a problem deploying
to
ack
GitHub Actions
Failure
Adds a few missing type annotations I found while working on another project. `mypy` flagged most of these with `no-untyped-call`. The others I found while updating the functions flagged by `mypy`.
schuylermartin45
force-pushed
the
main
branch
from
a0ee525 to
47615ba
Compare
schuylermartin45
had a problem deploying
to
ack
GitHub Actions
Failure
Author
|
Okay, I'm unclear what part I'm missing in the |
schuylermartin45
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few missing type annotations I found while working on another project.
mypyflagged most of these withno-untyped-call. The others I found while updating the functions flagged bymypy.