Skip to content

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 18, 2025

Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP.

(cherry picked from commit 6504f20)

Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP.

(cherry picked from commit 6504f20)
@vstinner
Copy link
Member Author

@Fidget-Spinner @corona10 @hugovk: Does it sound reasonable to you to make this macro private in 3.14? Sorry, it's a very late change in 3.14.

I would be fine with rejecting this PR and leaving the macro as it is in 3.14.

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think that it is safe to be merged at 3.14, but it's upto @hugovk want or not :)

@itamaro
Copy link
Contributor

itamaro commented Sep 19, 2025

lgtm, I think that it is safe to be merged at 3.14, but it's upto @hugovk want or not :)

Define "safe" ;)
It will require us to change how we're building 3.14 internally to avoid losing tail call interpreter.
Admittedly, our build is pretty far from "standard", and the adjustment would be trivial, but if we miss this change and don't adapt how we build, tail call interpreter would be silently turned off and it could be hard to notice, which would be unfortunate.

@vstinner
Copy link
Member Author

You don't use the configure option to enable the optimization?

@itamaro
Copy link
Contributor

itamaro commented Sep 19, 2025

No, we don't run configure when building with buck2

@hugovk
Copy link
Member

hugovk commented Oct 1, 2025

I think this is too late for 3.14.

@vstinner
Copy link
Member Author

vstinner commented Oct 1, 2025

I think this is too late for 3.14.

Sure, I'm fine with this decision.

@vstinner vstinner closed this Oct 1, 2025
@vstinner vstinner deleted the private_tail_cail314 branch October 1, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants