-
Notifications
You must be signed in to change notification settings - Fork 1.6k
DO NOT MERGE feat: fix SA version to 6 #5309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
Visual Regression Test Results ✅ Passed✨ No visual changes detected Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=278 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a hardcoded smart account version parameter to the secure site SDK URL and bumps the package version to 1.8.12.
- Adds
smartAccountVersionparameter set to 'v6' in the secure site SDK URL query string - Increments package version from 1.8.11 to 1.8.12
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/wallet/src/W3mFrame.ts | Adds smartAccountVersion query parameter with hardcoded value 'v6' to the SDK URL |
| packages/appkit/exports/constants.ts | Bumps package version to 1.8.12 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| url.searchParams.set('version', SECURE_SITE_SDK_VERSION) | ||
| url.searchParams.set('enableLogger', String(enableLogger)) | ||
| url.searchParams.set('rpcUrl', rpcUrl) | ||
| url.searchParams.set('smartAccountVersion', 'v6') |
Copilot
AI
Nov 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The smartAccountVersion value 'v6' is hardcoded. Consider making this configurable through the W3mFrameConfig interface to allow flexibility for future version changes or different deployment scenarios. This would improve maintainability and avoid requiring code changes when the smart account version needs to be updated.
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/[email protected] size /home/runner/work/appkit/appkit > size-limit |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Description
Deploy preview to sa version 6
Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist
Note
Pins smart account version to v6 in
W3mFramesecure SDK URL and bumps package version to 1.8.12.packages/wallet/src/W3mFrame.ts: AppendsmartAccountVersionquery param set tov6increateSecureSiteSdkUrl.packages/appkit/exports/constants.ts: BumpPACKAGE_VERSIONto1.8.12.Written by Cursor Bugbot for commit 5ea3b13. This will update automatically on new commits. Configure here.