Skip to content

Conversation

@tomiir
Copy link
Collaborator

@tomiir tomiir commented Nov 3, 2025

Description

Deploy preview to sa version 6

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-xxx
For GH issues: closes #...

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Note

Pins smart account version to v6 in W3mFrame secure SDK URL and bumps package version to 1.8.12.

  • Wallet:
    • packages/wallet/src/W3mFrame.ts: Append smartAccountVersion query param set to v6 in createSecureSiteSdkUrl.
  • Versioning:
    • packages/appkit/exports/constants.ts: Bump PACKAGE_VERSION to 1.8.12.

Written by Cursor Bugbot for commit 5ea3b13. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings November 3, 2025 12:44
@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2025

⚠️ No Changeset found

Latest commit: 5ea3b13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Nov 3, 2025 0:48am
appkit-demo Ready Ready Preview Comment Nov 3, 2025 0:48am
appkit-gallery Ready Ready Preview Comment Nov 3, 2025 0:48am
appkit-laboratory Ready Ready Preview Comment Nov 3, 2025 0:48am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Nov 3, 2025 0:48am
appkit-basic-sign-client-example Ignored Ignored Nov 3, 2025 0:48am
appkit-basic-up-example Ignored Ignored Nov 3, 2025 0:48am
appkit-ethers5-bera Ignored Ignored Nov 3, 2025 0:48am
appkit-nansen-demo Ignored Ignored Nov 3, 2025 0:48am
appkit-vue-solana Ignored Ignored Nov 3, 2025 0:48am
appkit-wagmi-cdn-example Ignored Ignored Nov 3, 2025 0:48am
ethereum-provider-wagmi-example Ignored Ignored Nov 3, 2025 0:48am
next-wagmi-solana-bitcoin-example Ignored Ignored Nov 3, 2025 0:48am
vue-wagmi-example Ignored Ignored Nov 3, 2025 0:48am

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Visual Regression Test Results ✅ Passed

✨ No visual changes detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=278
Storybook Preview: https://6493191bf4b10fed8ca7353f-hqdwbzokqy.chromatic.com/

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a hardcoded smart account version parameter to the secure site SDK URL and bumps the package version to 1.8.12.

  • Adds smartAccountVersion parameter set to 'v6' in the secure site SDK URL query string
  • Increments package version from 1.8.11 to 1.8.12

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/wallet/src/W3mFrame.ts Adds smartAccountVersion query parameter with hardcoded value 'v6' to the SDK URL
packages/appkit/exports/constants.ts Bumps package version to 1.8.12

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

url.searchParams.set('version', SECURE_SITE_SDK_VERSION)
url.searchParams.set('enableLogger', String(enableLogger))
url.searchParams.set('rpcUrl', rpcUrl)
url.searchParams.set('smartAccountVersion', 'v6')
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The smartAccountVersion value 'v6' is hardcoded. Consider making this configurable through the W3mFrameConfig interface to allow flexibility for future version changes or different deployment scenarios. This would improve maintainability and avoid requiring code changes when the smart account version needs to be updated.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/[email protected] size /home/runner/work/appkit/appkit


> size-limit

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         70.62 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 352 ms   on Snapdragon 410
Total time:   1.8 s
@reown/appkit/react
Size limit:   230 kB
Size:         227.29 kB with all dependencies, minified and gzipped
Loading time: 4.5 s     on slow 3G
Running time: 1.3 s     on Snapdragon 410
Total time:   5.7 s
@reown/appkit/vue
Size limit:   80 kB
Size:         70.62 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 391 ms   on Snapdragon 410
Total time:   1.8 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         207.3 kB with all dependencies, minified and gzipped
Loading time: 4.1 s    on slow 3G
Running time: 732 ms   on Snapdragon 410
Total time:   4.8 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms   on slow 3G
Running time: 99 ms    on Snapdragon 410
Total time:   356 ms

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.89% 37997 / 47560
🔵 Statements 79.89% 37997 / 47560
🔵 Functions 77.94% 4103 / 5264
🔵 Branches 86.51% 9208 / 10643
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/appkit/exports/constants.ts 100% 100% 100% 100%
packages/wallet/src/W3mFrame.ts 97.91% 82.14% 76.47% 97.91% 41-42, 105-106
Generated in workflow #16154 for commit 5ea3b13 by the Vitest Coverage Report Action

@tomiir tomiir closed this Nov 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants