Add GPIO interrupt managing methods #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romancardenas
requested changes
Oct 16, 2025
added 2 commits
October 21, 2025 13:07
…m Gpio0 to DeviceGpioPins
dmunizu
force-pushed
the
gpio-interrupt
branch
from
42f9cfc to
981be9f
Compare
romancardenas
requested changes
Oct 22, 2025
e310x-hal/src/device.rs
Outdated
| /// interrupt enable bits in the GPIO peripheral. You must call the | ||
| /// [`enable_exti()`](super::gpio::gpio0::Pin0::enable_exti) method of every pin | ||
| /// to enable their interrupt in the PLIC. | ||
| pub fn enable_interrupts(&self, event: EventType) { |
There was a problem hiding this comment.
Suggested change
| pub fn enable_interrupts(&self, event: EventType) { | |
| pub fn enable_interrupts(&mut self, event: EventType) { |
e310x-hal/src/device.rs
Outdated
| } | ||
|
|
||
| /// Disables the specified interrupt event for all the GPIO pins. | ||
| pub fn disable_interrupts(&self, event: EventType) { |
There was a problem hiding this comment.
Suggested change
| pub fn disable_interrupts(&self, event: EventType) { | |
| pub fn disable_interrupts(&mut self, event: EventType) { |
e310x-hal/src/device.rs
Outdated
| } | ||
|
|
||
| /// Clears the specified interrupt event pending flag for all the GPIO pins. | ||
| pub fn clear_interrupts(&self, event: EventType) { |
There was a problem hiding this comment.
Suggested change
| pub fn clear_interrupts(&self, event: EventType) { | |
| pub fn clear_interrupts(&mut self, event: EventType) { |
e310x-hal/src/gpio.rs
Outdated
| /// # Safety | ||
| /// | ||
| /// Enabling an interrupt source can break mask-based critical sections. | ||
| pub unsafe fn enable_exti(&self, plic: &Plic) { |
There was a problem hiding this comment.
Suggested change
| pub unsafe fn enable_exti(&self, plic: &Plic) { | |
| pub unsafe fn enable_exti(&mut self, plic: &Plic) { |
e310x-hal/src/gpio.rs
Outdated
| } | ||
|
|
||
| /// Disables the external interrupt source for the pin. | ||
| pub fn disable_exti(&self, plic: &Plic) { |
There was a problem hiding this comment.
Suggested change
| pub fn disable_exti(&self, plic: &Plic) { | |
| pub fn disable_exti(&mut self, plic: &Plic) { |
e310x-hal/src/gpio.rs
Outdated
| /// # Safety | ||
| /// | ||
| /// Changing the priority level can break priority-based critical sections. | ||
| pub unsafe fn set_exti_priority(&self, plic: &Plic, priority: Priority) { |
There was a problem hiding this comment.
Suggested change
| pub unsafe fn set_exti_priority(&self, plic: &Plic, priority: Priority) { | |
| pub unsafe fn set_exti_priority(&mut self, plic: &Plic, priority: Priority) { |
e310x-hal/src/gpio.rs
Outdated
| /// interrupt enable bit in the GPIO peripheral. You must call | ||
| /// [`enable_exti()`](Self::enable_exti) to enable the interrupt in | ||
| /// the PLIC. | ||
| pub fn enable_interrupt(&self, event: EventType) { |
There was a problem hiding this comment.
Suggested change
| pub fn enable_interrupt(&self, event: EventType) { | |
| pub fn enable_interrupt(&mut self, event: EventType) { |
e310x-hal/src/gpio.rs
Outdated
| } | ||
|
|
||
| /// Disables the selected interrupts for the pin in the interrupt enable registers | ||
| pub fn disable_interrupt(&self, event: EventType) { |
There was a problem hiding this comment.
Suggested change
| pub fn disable_interrupt(&self, event: EventType) { | |
| pub fn disable_interrupt(&mut self, event: EventType) { |
e310x-hal/src/gpio.rs
Outdated
| } | ||
|
|
||
| /// Clears pending interrupts for the selected pin interrupts. | ||
| pub fn clear_interrupt(&self, event: EventType) { |
There was a problem hiding this comment.
Suggested change
| pub fn clear_interrupt(&self, event: EventType) { | |
| pub fn clear_interrupt(&mut self, event: EventType) { |
romancardenas
requested changes
Oct 23, 2025
| let plic = cp.plic; | ||
| let priorities = plic.priorities(); | ||
| priorities.reset::<ExternalInterrupt>(); | ||
| unsafe { priorities.set_priority(ExternalInterrupt::GPIO9, Priority::P1) }; |
There was a problem hiding this comment.
Remove this:
Suggested change
| unsafe { priorities.set_priority(ExternalInterrupt::GPIO9, Priority::P1) }; |
romancardenas
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods for the GPIO and Pin structs for the user to easily work with interrupts without dealing with direct register modification.
The button_interrupt.rs example has been adapted to this new functionality.