feat(eslint): add support for flat configs #1898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint v8.57 has added a new loadESLint() function to load the correct ESLint class (either one reading legacy configs, either one reading flat configs). See: - https://eslint.org/docs/v8.x/integrate/nodejs-api#loadeslint - eslint/eslint@1120b9b Unfortunately @types/eslint is missing v8.57 and has been removed entirely from the DefinitelyType repository (since upstream now ships type definitions). As a result we need to manually declare the type of the loadESLint() function. Additionally, loadESLint() is async, so we can't call it at plugin initialization time. Instead, we call it the first time we need it.
emersion
force-pushed
the
eslint-flat-config
branch
from
86d95ba to
9c967dd
Compare
This was referenced Sep 22, 2025
|
Hi @shellscape, would you have time to look at this PR by any chance? Thanks! |
shellscape
approved these changes
Oct 4, 2025
|
Thank you! |
emersion
added a commit
to OpenRailAssociation/osrd
that referenced
this pull request
Oct 4, 2025
This is required to get support for flat config files: rollup/plugins#1898 Signed-off-by: Simon Ser <[email protected]>
github-merge-queue bot
pushed a commit
to OpenRailAssociation/osrd
that referenced
this pull request
Oct 4, 2025
This is required to get support for flat config files: rollup/plugins#1898 Signed-off-by: Simon Ser <[email protected]>
github-merge-queue bot
pushed a commit
to OpenRailAssociation/osrd
that referenced
this pull request
Oct 4, 2025
This is required to get support for flat config files: rollup/plugins#1898 Signed-off-by: Simon Ser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
eslintThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
ESLint v8.57 has added a new loadESLint() function to load the correct ESLint class (either one reading legacy configs, either one reading flat configs).
See:
Unfortunately @types/eslint is missing v8.57 and has been removed entirely from the DefinitelyType repository (since upstream now ships type definitions). As a result we need to manually declare the type of the loadESLint() function.
Additionally, loadESLint() is async, so we can't call it at plugin initialization time. Instead, we call it the first time we need it.
See also these issues:
eslint.config.jsis not recognized #1708