Feature/static constants for flags and envelope types added #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverweed
reviewed
Jul 8, 2025
modules/rntuple.mjs
Outdated
| class RNTupleDescriptorBuilder { | ||
|
|
||
| // Envelope Types | ||
| static kEnvelopeTypeHeader = 0x01; |
There was a problem hiding this comment.
I would define these outside the class as const, to avoid them being mutable.
silverweed
requested changes
Jul 8, 2025
Co-authored-by: Silverweed <[email protected]>
silverweed
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.