Skip to content

Feature/static constants for flags and envelope types added #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025
Merged

Feature/static constants for flags and envelope types added #349

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a85742
added static constants for flags
Krmjn09 Jul 8, 2025
dfc5d39
changes done
Krmjn09 Jul 8, 2025
35a2236
Update modules/rntuple.mjs
Krmjn09 Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions modules/rntuple.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,18 @@ class RBufferReader {

class RNTupleDescriptorBuilder {

// Envelope Types
static kEnvelopeTypeHeader = 0x01;
Copy link
Contributor

@silverweed silverweed Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would define these outside the class as const, to avoid them being mutable.

Copy link
Collaborator Author

@Krmjn09 Krmjn09 Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok i will do that

static kEnvelopeTypeFooter = 0x02;
static kEnvelopeTypePageList = 0x03;
// Field Flags
static kFlagRepetitiveField = 0x01;
static kFlagProjectedField = 0x02;
static kFlagHasTypeChecksum = 0x04;
// Column Flags
static kFlagDeferredColumn = 0x01;
static kFlagHasValueRange = 0x02;

deserializeHeader(header_blob) {
if (!header_blob) return;

Expand Down Expand Up @@ -246,9 +258,15 @@ class RNTupleDescriptorBuilder {
sourceFieldId = null,
checksum = null;

if (flags & 0x1) arraySize = reader.readU64();
if (flags & 0x2) sourceFieldId = reader.readU32();
if (flags & 0x4) checksum = reader.readU32();
if (flags & RNTupleDescriptorBuilder.kFlagRepetitiveField)
arraySize = reader.readU64();

if (flags & RNTupleDescriptorBuilder.kFlagProjectedField)
sourceFieldId = reader.readU32();

if (flags & RNTupleDescriptorBuilder.kFlagHasTypeChecksum)
checksum = reader.readU32();


fieldDescriptors.push({
fieldVersion,
Expand Down Expand Up @@ -289,8 +307,11 @@ class RNTupleDescriptorBuilder {
let firstElementIndex = null,
minValue = null,
maxValue = null;
if (flags & 0x1) firstElementIndex = reader.readU64();
if (flags & 0x2) {

if (flags & RNTupleDescriptorBuilder.kFlagDeferredColumn)
firstElementIndex = reader.readU64();

if (flags & RNTupleDescriptorBuilder.kFlagHasValueRange) {
minValue = reader.readF64();
maxValue = reader.readF64();
}
Expand All @@ -307,7 +328,7 @@ class RNTupleDescriptorBuilder {
maxValue
};
column.isDeferred = function() {
return (this.flags & 0x01) !== 0;
return (this.flags & RNTupleDescriptorBuilder.kFlagDeferredColumn) !== 0;
};
column.isSuppressed = function() {
return this.firstElementIndex !== null && this.firstElementIndex < 0;
Expand Down