Skip to content

Fix assumption that CMAKE_INSTALL_*DIR paths are relative.#90

Merged
scpeters merged 1 commit intoros:rollingfrom
wentasah:cmake-absolute-paths
Feb 6, 2026
Merged

Fix assumption that CMAKE_INSTALL_*DIR paths are relative.#90
scpeters merged 1 commit intoros:rollingfrom
wentasah:cmake-absolute-paths

Conversation

@wentasah
Copy link
Contributor

This solution uses relative paths if possible, allowing the package to be relocatable, but still works correctly if CMAKE_INSTALL_*DIR paths are absolute.

New version of #66 and #78, which fixes conflicts with latest rolling.

This solution uses relative paths if possible, allowing the package to be
relocatable, but still works correctly if CMAKE_INSTALL_*DIR paths are absolute.

Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com>
@scpeters scpeters merged commit 6552c9d into ros:rolling Feb 6, 2026
2 checks passed
@fujitatomoya
Copy link

@scpeters @wentasah can you revert this? this generates the regression in CI, since Friday Feb-6.

@ahcorde
Copy link
Contributor

ahcorde commented Feb 9, 2026

@scpeters When merging PRs in the ros2 core we need to run the CI https://ci.ros2.org/job/ci_launcher/ or you can also run this script https://github.com/ros-tooling/ros-github-scripts

ahcorde added a commit that referenced this pull request Feb 9, 2026
@scpeters
Copy link
Contributor

scpeters commented Feb 9, 2026

sorry about that; I'll slow down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments