Skip to content

Add support for corepc #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apoelstra merged 1 commit into from
Feb 14, 2025
Merged

Add support for corepc #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions ci/run_task.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,9 @@ build_and_test() {
verbose_say "FEATURES_WITH_NO_STD: ${FEATURES_WITH_NO_STD}"
verbose_say "FEATURES_WITHOUT_STD: ${FEATURES_WITHOUT_STD}"
verbose_say "EXAMPLES: ${EXAMPLES:-}"
if [[ -v EXACT_FEATURES && ${#EXACT_FEATURES[@]} -gt 0 ]]; then
verbose_say "EXACT_FEATURES: ${EXACT_FEATURES[*]}"
fi
fi
pushd "$REPO_DIR/$crate" > /dev/null

Expand Down Expand Up @@ -164,8 +167,14 @@ do_test() {
# Each crate defines its own feature matrix test so feature combinations
# can be better controlled.
do_feature_matrix() {
# For crates that have unusual feature requirements (e.g. `corepc`).
if [[ -v EXACT_FEATURES && ${#EXACT_FEATURES[@]} -gt 0 ]]; then
for features in "${EXACT_FEATURES[@]}"; do
$cargo build --no-default-features --features="$features"
$cargo test --no-default-features --features="$features"
done
# rust-miniscript only: https://github.com/rust-bitcoin/rust-miniscript/issues/681
if [ -n "${FEATURES_WITH_NO_STD}" ]; then
elif [ -n "${FEATURES_WITH_NO_STD}" ]; then
$cargo build --no-default-features --features="no-std"
$cargo test --no-default-features --features="no-std"

Expand Down Expand Up @@ -219,10 +228,14 @@ loop_features() {
do_lint() {
need_nightly

# Lint various feature combinations to try and catch mistakes in feature gating.
$cargo clippy --workspace --all-targets --keep-going -- -D warnings
$cargo clippy --workspace --all-targets --all-features --keep-going -- -D warnings
$cargo clippy --workspace --all-targets --no-default-features --keep-going -- -D warnings

# Ugly hack to skip `corpec` because `node` does not build with no default features.
if echo "$REPO_DIR" | grep -viq "corepc"; then
# Lint various feature combinations to try and catch mistakes in feature gating.
$cargo clippy --workspace --all-targets --keep-going -- -D warnings
$cargo clippy --workspace --all-targets --no-default-features --keep-going -- -D warnings
fi
}

# We should not have any duplicate dependencies. This catches mistakes made upgrading dependencies
Expand Down Expand Up @@ -343,3 +356,4 @@ need_nightly() {
#
main "$@"
exit 0