Add support for corepc #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `corpec` repository excludes the `node` crate because it has unusual feature requirements - it requires at least one version feature. Add support for testing `node`. The logic in `build_and_test` is general and uses a new var defined in `contrib/test_vars.sh` but does not require this var to exist. The logic in `do_lint` is ugly and specific to `node`. I couldn't think of a cleaner way to do it.
tcharding
force-pushed
the
02-12-support-corepc
branch
from
704b5dc to
d6bcfac
Compare
tcharding
added a commit
to tcharding/corepc
that referenced
this pull request
Feb 11, 2025
Currently we do not include the `node` crate in the workspace because `run_task` did not support testing it. However `run_task` is patched in rust-bitcoin/rust-bitcoin-maintainer-tools#19 So we can use it now. Include `node` in the workspace. Configure it to work with the newly patched `run_task`. Add a `extra_tests.sh` script that runs the `node` tests.
tcharding
added a commit
to tcharding/corepc
that referenced
this pull request
Feb 11, 2025
Currently we do not include the `node` crate in the workspace because `run_task` did not support testing it. However `run_task` is patched in rust-bitcoin/rust-bitcoin-maintainer-tools#19 So we can use it now. Include `node` in the workspace. Configure it to work with the newly patched `run_task`. Add a `extra_tests.sh` script that runs the `node` tests.
tcharding
added a commit
to tcharding/corepc
that referenced
this pull request
Feb 12, 2025
Currently we do not include the `node` crate in the workspace because `run_task` did not support testing it. However `run_task` is patched in rust-bitcoin/rust-bitcoin-maintainer-tools#19 So we can use it now. Include `node` in the workspace. Configure it to work with the newly patched `run_task`. Add a `extra_tests.sh` script that runs the `node` tests.
tcharding
added a commit
to tcharding/corepc
that referenced
this pull request
Feb 12, 2025
Currently we do not include the `node` crate in the workspace because `run_task` did not support testing it. However `run_task` is patched in rust-bitcoin/rust-bitcoin-maintainer-tools#19 So we can use it now. Include `node` in the workspace. Configure it to work with the newly patched `run_task`. Add a `extra_tests.sh` script that runs the `node` tests. In order to get MSRV building we make all deps use `default-features = false` then explicitly enable just what we need.
tcharding
added a commit
to tcharding/corepc
that referenced
this pull request
Feb 12, 2025
Currently we do not include the `node` crate in the workspace because `run_task` did not support testing it. However `run_task` is patched in rust-bitcoin/rust-bitcoin-maintainer-tools#19 So we can use it now. Include `node` in the workspace. Configure it to work with the newly patched `run_task`. Add a `extra_tests.sh` script that runs the `node` tests. In order to get MSRV building we make all deps use `default-features = false` then explicitly enable just what we need.
Member
|
In d6bcfac: This seems reasonable to me. I think that we could make this a bit simpler and more general though -- rather than having a whitelist of exact features that we need to keep up to date, we could have a blacklist of feature combos that aren't allowed. (Or even just a flag to blacklist "no features at all", which is really all we need.) I think we can use the same blacklist in the clippy thing -- so rather than special-casing corepc we special-case "crates that can't be built with the empty feature set". But what you've done here is ok with me. This repo is inherently going to be crufty and need some special-cases, and isn't necessarily supposed to be easily usable outside the rust-bitcoin ecosystem. |
Member
Author
|
Cool. Lets merge as is and I can improve it at another time if/when I get motivation. |
Member
|
ACK d6bcfac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
corpecrepository excludes thenodecrate because it has unusual feature requirements - it requires at least one version feature.Add support for testing
node. The logic inbuild_and_testis general and uses a new var defined incontrib/test_vars.shbut does not require this var to exist.The logic in
do_lintis ugly and specific tonode. I couldn't think of a cleaner way to do it.