Skip to content

Simplify riscv::interrupt::machine::nested #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

Simplify riscv::interrupt::machine::nested #283

merged 1 commit into from
May 1, 2025
+6 −4

Conversation

@romancardenas
Copy link
Contributor

Just simplify the nested function for M-mode, following the same fashion as for S-mode.

@romancardenas romancardenas requested a review from a team as a code owner April 30, 2025 12:48
rmsyn
rmsyn approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@rmsyn rmsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, with the set_ functions using the RISCV asm to only update the relevant bitfield, it makes sense to just use those methods.

That was the original intention of updating the in-memory struct, so this simplification is the right idea.

@romancardenas romancardenas added this pull request to the merge queue May 1, 2025
Merged via the queue into master with commit cb6a264 May 1, 2025
138 checks passed
@romancardenas romancardenas deleted the simple-mnested branch June 4, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmsyn rmsyn rmsyn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romancardenas @rmsyn