-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Emit disallowed_names lint for functions #14601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Emit disallowed_names lint for functions #14601
Conversation
This comment has been minimized.
This comment has been minimized.
103b261 to
992f226
Compare
|
Hi @y21, this PR is ready for review now - could I kindly ask you to take a look when you have a moment? The changes are a bit large, but they primarily involve two updates:
Let me know if you have any questions. Thanks in advance! |
This comment has been minimized.
This comment has been minimized.
1c726a6 to
0bda6b2
Compare
This comment has been minimized.
This comment has been minimized.
dc779cd to
76af243
Compare
|
Hello @y21, I updated the PR to include the up-to-date master branch. |
|
☔ The latest upstream changes (possibly f8a3929) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Sorry for the long wait. This change makes sense to me, although given the impact on the tests I created a thread on Zulip to see if there's concerns with this: https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/disallowed_names.20for.20function.20names Going to leave that for a few days and if nothing comes up then I'd say we're good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably ignore functions in testing modules.
This PR fixes a part of #11306.
Note that
disallowed_namesstill doesn't warn about using disallowed struct (and its field) /module/crate names. I'm planning to address this in a separate PR (if it makes sense to you).The changes are a bit large, but they primarily involve two updates:
changelog: [
disallowed_names]: Warn on usage of disallowed function names