Skip to content

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Sep 9, 2025

decided to put each lint extraction into a separate commit this time -- do let me know if you prefer all of that being in a single commit instead

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 9, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash the commits together ("split returns module), except maybe the first one?

r? samueltardieu @bors author

View changes since this review

@rustbot rustbot assigned samueltardieu and unassigned Alexendoo Sep 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ada4a
Copy link
Contributor Author

ada4a commented Sep 13, 2025

done!

@samueltardieu
Copy link
Member

I'll merge this, but did you need to rebase it? If this is not the case, you should avoid it as it makes the review a bit harder in the general case. The PR will be tested against master anyway (which is why it cannot be tested if there is a merge conflict).

@samueltardieu samueltardieu added this pull request to the merge queue Sep 13, 2025
@ada4a
Copy link
Contributor Author

ada4a commented Sep 13, 2025

but did you need to rebase it?

I'm a rebase person at heart, and so all the merge commits kind of kill me inside, but especially so if they have a long tail due to the base of a PR being on some ancient commit, so I do tend to rebase right before the merge if I remember.

If this is not the case, you should avoid it as it makes the review a bit harder in the general case.

I'd hope the range-diff thing makes such noop rebases easier to spot and dismiss, but given that the reason for my rebasing is aesthetic at best, I can just not do it^^

Merged via the queue into rust-lang:master with commit 1d0582a Sep 13, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants