-
Notifications
You must be signed in to change notification settings - Fork 1.8k
refactor: split return
lints into separate modules
#15646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
627d110
to
121c7ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you squash the commits together ("split returns
module), except maybe the first one?
r? samueltardieu @bors author
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
done! |
I'll merge this, but did you need to rebase it? If this is not the case, you should avoid it as it makes the review a bit harder in the general case. The PR will be tested against |
I'm a rebase person at heart, and so all the merge commits kind of kill me inside, but especially so if they have a long tail due to the base of a PR being on some ancient commit, so I do tend to rebase right before the merge if I remember.
I'd hope the range-diff thing makes such noop rebases easier to spot and dismiss, but given that the reason for my rebasing is aesthetic at best, I can just not do it^^ |
decided to put each lint extraction into a separate commit this time -- do let me know if you prefer all of that being in a single commit instead
changelog: none