refactor: split return lints into separate modules

[ada4a]

decided to put each lint extraction into a separate commit this time -- do let me know if you prefer all of that being in a single commit instead

changelog: none

[rustbot]

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[samueltardieu]

Could you squash the commits together ("split returns module), except maybe the first one?

r? samueltardieu @bors author

View changes since this review

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[ada4a]

done!

[samueltardieu]

I'll merge this, but did you need to rebase it? If this is not the case, you should avoid it as it makes the review a bit harder in the general case. The PR will be tested against master anyway (which is why it cannot be tested if there is a merge conflict).

[ada4a]

but did you need to rebase it?

I'm a rebase person at heart, and so all the merge commits kind of kill me inside, but especially so if they have a long tail due to the base of a PR being on some ancient commit, so I do tend to rebase right before the merge if I remember.

If this is not the case, you should avoid it as it makes the review a bit harder in the general case.

I'd hope the range-diff thing makes such noop rebases easier to spot and dismiss, but given that the reason for my rebasing is aesthetic at best, I can just not do it^^