Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Conversation

@DreamWuGit
Copy link

@DreamWuGit DreamWuGit commented Aug 29, 2024

Description

currently eve circuit lacks pre-eip155 type test, add in this PR and related changes

  • get_utils trace support pre-eip155 type tx
  • add two tests in begin_tx testing
  • adapt MockTransaction to tx with entire signature data.

@DreamWuGit DreamWuGit changed the title Don't merge: add pre-eip155 evm circuit test WIP: add pre-eip155 evm circuit test Sep 6, 2024
@DreamWuGit DreamWuGit marked this pull request as ready for review September 11, 2024 03:30
@DreamWuGit DreamWuGit changed the title WIP: add pre-eip155 evm circuit test add pre-eip155 evm circuit test Sep 11, 2024
@lispc
Copy link

lispc commented Sep 12, 2024

leave some small comments

@lispc lispc merged commit 5ee0157 into develop Sep 18, 2024
10 checks passed
@lispc lispc deleted the pre-eip155 branch September 18, 2024 02:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants