fix: skip Alive =false backend before add job. #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wangwq10 That's a valid point, but the objective is to verify whether the enable_feature_binlog option of all BEs is enabled, if we skip any BE, the check constraint might be broken: some backends don't enable the binlog so the syncer could not download the binlog files when the backend becomes active again, and the replication will be stopped. |
fix: after pause update successfully, status/state should align to job.State and return "paused" as excepted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fist Doris cluster works fine even if lost some be.
In this case cluster have 5 BEs and one of them Alive = false, and replica all reallocated
It should be able to create a ccr job