Skip to content

fix: skip Alive =false backend before add job. #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix: skip Alive =false backend before add job. #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4569b9
fix: skip Alive =false backend before add job.
Mar 26, 2025
2cfb573
Merge branch 'selectdb:dev' into dev
wangwq10 May 23, 2025
aa160e5
Update job_manager.go
wangwq10 May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/ccr/base/backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ type Backend struct {
BePort uint16
HttpPort uint16
BrpcPort uint16
Alive bool
}

// Backend Stringer
Expand Down
2 changes: 2 additions & 0 deletions pkg/ccr/job_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,8 @@
defer jm.lock.RUnlock()

if job, ok := jm.jobs[jobName]; ok {
log.Debugf("job rawStatue: %s, job state:%s", job.rawStatus.state, job.State)
atomic.StoreInt32(&job.rawStatus.state, int32(job.State))

Check failure on line 221 in pkg/ccr/job_manager.go

View workflow job for this annotation

GitHub Actions / build 

undefined: atomic
return job.Status(), nil
} else {
return nil, xerror.Errorf(xerror.Normal, "job not exist: %s", jobName)
Expand Down
10 changes: 9 additions & 1 deletion pkg/ccr/meta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,11 @@ func (m *Meta) UpdateBackends() error {
return xerror.Wrapf(err, xerror.Normal, query)
}
backend.BrpcPort = uint16(port)

alive, err := rowParser.GetBool("Alive")
if err != nil {
return xerror.Wrapf(err, xerror.Normal, query)
}
backend.Alive = alive
log.Debugf("backend: %v", &backend)
backends = append(backends, &backend)
}
Expand Down Expand Up @@ -1212,6 +1216,10 @@ func (m *Meta) checkBEsBinlogFeature() error {

var disabledBinlogBEs []string
for _, backend := range backends {
if !backend.Alive {
log.Warnf("backend %v:%v is not alive, skip check", backend.Host, backend.HttpPort)
continue
}
url := fmt.Sprintf("http://%v:%v/api/show_config?conf_item=enable_feature_binlog",
backend.Host, backend.HttpPort)
resp, err := http.Get(url)
Expand Down
Loading