ci: upload test results using the recommended codecov action #1396
Conversation
zimeg
added
dependencies
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
🪬 A ramble for kind reviewers!
| uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5.5.1 | ||
| with: | ||
| directory: ./reports/ | ||
| fail_ci_if_error: true |
There was a problem hiding this comment.
👁️🗨️ note: We discussed changing this to false but that might've been the default used before! I believe changing this action to the recommended one while still keeping this erroring step might be alright for now, but I'm so open to revisiting this!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
=======================================
Coverage 91.05% 91.05%
=======================================
Files 222 222
Lines 7534 7534
=======================================
Hits 6860 6860
Misses 674 674 ☔ View full report in Codecov by Sentry. |
misscoded
left a comment
misscoded
left a comment
There was a problem hiding this comment.
I'm unfamiliar with our codecov setup, but LGTM. Feel free to wait for other reviewers prior to merging!
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Wow, thanks to staying on the ball and update this!
|
@misscoded @mwbrooks @WilliamBergamin I appreciate the reviews and shared findings toward improved CI 👾 |
Summary
This PR uses the recommended
codecov/codecov-actionto both upload test coverage and test results 🧪 ✨From the pages of the
codecov/test-results-actionaction:🔗 https://github.com/codecov/test-results-action?tab=readme-ov-file#%EF%B8%8F-deprecation-warning-%EF%B8%8F
Testing
Hopes to fix ongoing issues in CI:
⏳ https://github.com/slackapi/bolt-python/actions?query=event%3Aschedule
🤖 https://github.com/slackapi/bolt-python/actions/runs/19250630230/job/55034658717
Category
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.