DF-22956: add NORMALIZE_CASE_INPUTS setting for case-insensitive asset handling#717
Open
cl-efornaciari wants to merge 1 commit intomainfrom
Open
DF-22956: add NORMALIZE_CASE_INPUTS setting for case-insensitive asset handling#717cl-efornaciari wants to merge 1 commit intomainfrom
cl-efornaciari wants to merge 1 commit intomainfrom
Conversation
…ndling Adds a framework-level setting (default: true) that normalizes base and quote input parameters to uppercase before cache key computation and subscription registration. This prevents WebSocket subscription churn when the same asset is requested with different casings (e.g. USDe vs USDE). Adapters can opt out via envDefaultOverrides or the NORMALIZE_CASE_INPUTS env var for cases where case-sensitive identifiers are required. Refs: DF-22956
5 tasks
Contributor
|
👋 cl-efornaciari, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
NPM Publishing labels 🏷️🛑 This PR needs labels to indicate how to increase the current package version in the automated workflows. Please add one of the following labels: |
cl-efornaciari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NORMALIZE_CASE_INPUTSframework-level setting (defaulttrue) that uppercasesbaseandquoteinput parameters before cache key computation and subscription registration, eliminating subscription churn and data loss caused by mixed-case requests for the same asset (e.g.USDe/USDvsUSDE/USD).normalizeInputCaseas a built-in request transform inAdapterEndpoint, ordered aftersymbolOverriderand before adapter-specific transforms.envDefaultOverrides: { NORMALIZE_CASE_INPUTS: 'false' }.envDefaultOverridesopt-out, interaction withsymbolOverrider, and adapter-specific transform ordering.Jira
DF-22956
Test plan
symbolOverriderenvDefaultOverridesopt-outbaseandquotefields are affected (not other params)