Add support for custom GrpcServerObservationConvention#49730
Merged
snicoll merged 2 commits intospring-projects:mainfrom Mar 25, 2026
Merged
Add support for custom GrpcServerObservationConvention#49730snicoll merged 2 commits intospring-projects:mainfrom
snicoll merged 2 commits intospring-projects:mainfrom
Conversation
therepanic
changed the title
GrpcServerObservationConvention in GrpcServerObservationAutoConfiguration
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
changed the title
GrpcServerObservationConvention in GrpcServerObservationAutoConfiguration
In this commit, we make `GrpcServerObservationAutoConfiguration` and `GrpcClientObservationAutoConfiguration` consistent by supporting a custom `GrpcClientObservationConvention` and adding the `@ConditionalOnMissingBean` annotation to the `observationGrpcServerInterceptor` bean. See spring-projectsgh-49730 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
snicoll
changed the title
snicoll
added
type: enhancement
snicoll
force-pushed
the
apply-keepalive-settings
branch
from
1396450 to
3ebc865
Compare
snicoll
added a commit
to therepanic/spring-boot
that referenced
this pull request
Mar 26, 2026
Such parameters are usually named "customConvention" so this commit aligns to that naming. See spring-projectsgh-49730
snicoll
added a commit
that referenced
this pull request
Mar 26, 2026
* polish-GrpcClientObservationAutoConfiguration: Harmonize ObservationConvention parameters in gRPC support Rename GrpcClientObservationConvention parameter to convention Closes gh-49730
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we make
GrpcServerObservationAutoConfigurationandGrpcClientObservationAutoConfigurationconsistent by supporting a customGrpcClientObservationConventionand adding the@ConditionalOnMissingBeanannotation to theobservationGrpcServerInterceptorbean.Original PR: spring-projects/spring-grpc#390