Support custom GrpcServerObservationConvention in GrpcServerObservationAutoConfiguration#390
Closed
therepanic wants to merge 1 commit intospring-projects:mainfrom
Closed
Support custom GrpcServerObservationConvention in GrpcServerObservationAutoConfiguration#390therepanic wants to merge 1 commit intospring-projects:mainfrom
GrpcServerObservationConvention in GrpcServerObservationAutoConfiguration#390therepanic wants to merge 1 commit intospring-projects:mainfrom
Conversation
…onAutoConfiguration In this commit, we make `GrpcServerObservationAutoConfiguration` and `GrpcClientObservationAutoConfiguration` consistent by supporting a custom `GrpcClientObservationConvention` and adding the `@ConditionalOnMissingBean` annotation to the `observationGrpcServerInterceptor` bean. Closes: spring-projectsgh-389 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
commented
Mar 17, 2026
| @GlobalServerInterceptor | ||
| ObservationGrpcServerInterceptor observationGrpcServerInterceptor(ObservationRegistry observationRegistry) { | ||
| return new ObservationGrpcServerInterceptor(observationRegistry); | ||
| @ConditionalOnMissingBean |
Contributor
Author
There was a problem hiding this comment.
lets add this too like in GrpcClientAutoConfiguration
dsyer
added
the
status: post-spring-boot-migration
Contributor
Author
|
Closing in favor of: spring-projects/spring-boot#49730 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this commit, we make
GrpcServerObservationAutoConfigurationandGrpcClientObservationAutoConfigurationconsistent by supporting a customGrpcClientObservationConventionand adding the@ConditionalOnMissingBeanannotation to theobservationGrpcServerInterceptorbean.Closes: gh-389