feat: Apply "Option for viewing sr decks and cards in tabs" feature to Ribbon callback

[bcdax110]

I wanted to try the feature in #1169, so I built it from the latest version and found that it didn’t work. Later, I discovered that it worked when opened via command, but it didn’t work when opened via Ribbon. I guessed that the Ribbon callback might have been forgotten to be modified. So, I referred to the command callback implementation and modified the Ribbon callback part accordingly.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (d11a10a) to head (e294074).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
- Coverage   93.69%   93.15%   -0.54%     
==========================================
  Files          42       42              
  Lines        4662     4662              
  Branches      663      375     -288     
==========================================
- Hits         4368     4343      -25     
- Misses        289      317      +28     
+ Partials        5        2       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[BlitzVI]

i can confirm it still doesn't seem to work if i access the flashcards from the ribbon but works if i use the command to access the flashcards

[bcdax110]

i can confirm it still doesn't seem to work if i access the flashcards from the ribbon but works if i use the command to access the flashcards

I have been using this modified version for a while (on Windows and iOS), and it can open as a tab from the ribbon.

Which version of the plugin are you using? If it's the releases version, it indeed won't work because the code hasn't been merged yet.

[BlitzVI]

i can confirm it still doesn't seem to work if i access the flashcards from the ribbon but works if i use the command to access the flashcards

I have been using this modified version for a while (on Windows and iOS), and it can open as a tab from the ribbon.

Which version of the plugin are you using? If it's the releases version, it indeed won't work because the code hasn't been merged yet.

yeah im still using the release version. How can i use this modified version that u are using?

[bcdax110]

i can confirm it still doesn't seem to work if i access the flashcards from the ribbon but works if i use the command to access the flashcards

I have been using this modified version for a while (on Windows and iOS), and it can open as a tab from the ribbon.
Which version of the plugin are you using? If it's the releases version, it indeed won't work because the code hasn't been merged yet.

yeah im still using the release version. How can i use this modified version that u are using?

Sorry for the late reply.

I built a version with the modifications after merging the updates from the st3v3nmw:master branch.

If you'd like to use it directly, you can use the main.js inside the main.zip to replace .obsidian/plugins/obsidian-spaced-repetition/main.js, and re-enable the plugin in Obsidian.

If you'd prefer to compile it yourself:

1. install Node.js and pnpm(run the commandnpm install -g pnpm after install node.js ).
2. download the code from https://github.com/bcdax110/obsidian-spaced-repetition/tree/master, and in the project directory, run the commands pnpm install and pnpm build.
3. After that, you'll find the generated build/main.js.