-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
UI: Add WithPopover and port relevant internals to use it [1/3] #32492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add WithPopover and port relevant internals to use it [1/3] #32492
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Comment |
|
View your CI Pipeline Execution ↗ for commit 7159dd5
☁️ Nx Cloud last updated this comment at |
3ff64df to
96d360a
Compare
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 43 | 43 | 0 |
| Self size | 31.96 MB | 34.86 MB | 🚨 +2.90 MB 🚨 |
| Dependency size | 17.30 MB | 17.30 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 187 | 187 | 0 |
| Self size | 886 KB | 886 KB | 🎉 -84 B 🎉 |
| Dependency size | 81.55 MB | 84.46 MB | 🚨 +2.90 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 169 | 169 | 0 |
| Self size | 35 KB | 35 KB | 🚨 +42 B 🚨 |
| Dependency size | 77.98 MB | 80.88 MB | 🚨 +2.90 MB 🚨 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 44 | 44 | 0 |
| Self size | 1.55 MB | 1.55 MB | 🚨 +30 B 🚨 |
| Dependency size | 49.25 MB | 52.16 MB | 🚨 +2.90 MB 🚨 |
| Bundle Size Analyzer | node | node |
e940687 to
fa2c259
Compare
96d360a to
f73ab72
Compare
166c0f2 to
d291255
Compare
b2512c8 to
65416c9
Compare
|
I've ported Modal to react-aria and fixed up the modal navigation dialogs that had been having tooltip overlap issues for a few months. This was an opportunity to remove a Radix package and replace react-transition-group by something better maintained and lighter. |
bf7309f to
8a4ab57
Compare
8d76f19 to
f1551fe
Compare

Works towards closing #32249
What I did
Added WithPopover
placementpropAdded Popover
hasChromecolorexposed on the old tooltip to only allow accessible colour pairingsMade Link forward refs
Ported Controls/Color picker to use popover
Ported Select to use popover
Ported ContextMenu to use popover
Ported Sidebar Menu to use popover
Ported RefBlocks / RefIndicators to use popover
These are the components powering composed Storybooks in the sidebar.
Ported TagsFilter to use popover
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
unit testsManual testing
yarn storybook:uiDocumentation
N/A
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>