chore: remove unconditioned instrument code

[stormslowly]

To check if tracing has a performance cost

Description:

BREAKING CHANGE:

Related issue (if exists):

[changeset-bot]

⚠️ No Changeset found

Latest commit: 182dc3a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[kdy1]

It has a noticeable cost. You can try enabling tracing/max_level_off

[codspeed-hq]

CodSpeed Performance Report

Merging #11237 will not alter performance

_{Comparing stormslowly:chore/try_no_instrument (182dc3a) with main (d93ec90)}

Summary

✅ 138 untouched

[stormslowly]

In rspack-resolver, when I enable max_level_off and release_max_level_off, I still get 2~15% performance loss in benchmark.

[github-actions]

Binary Sizes

File	Size
swc.linux-x64-gnu.node	31M (31818120 bytes)

Commit: f4fda6e

[kdy1]

I think it's a good idea to remove all tracing code, considering the perf difference

[stormslowly]

According to codspeed's report, the most improved step is enabling max_level_off.
That's quite different from rspack-resolver's case.
I will do some digging to find the season and figure out a way to improve performance and keep trackability.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	jest@​29.7.0
	expect@​27.5.1
	react@​17.0.2
	regenerator-runtime@​0.13.11
	npm-run-all@​4.1.5
	reflect-metadata@​0.1.14
	husky@​7.0.4
	sourcemap-validator@​2.1.0
	glob@​8.1.0
	ts-node@​10.9.1
	prop-types@​15.8.1
	yaml@​2.4.5
	source-map-support@​0.5.21
	lodash@​4.17.21
	swc-plugin-coverage-instrument@​0.0.26
	cross-env@​7.0.3
	js-beautify@​1.14.7
	progress@​2.0.3
	zx@​8.1.4
	terser@​5.17.6
	prettier@​2.8.8
	typescript@​5.3.3
	cspell@​5.21.2
	mocha@​9.2.2
	lint-staged@​12.5.0

View full report