Remove experimental status from worker tuners #2683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejdudko
requested changes
Oct 15, 2025
Comment on lines
10
to
11
| */ | ||
| @Experimental | ||
| public interface PollerBehavior {} |
There was a problem hiding this comment.
Is it intentional to also move poller behavior out of experimental too? If so, it's still marked experimental inside WorkerOptions.
There was a problem hiding this comment.
No, this wasn't intentional, good catch. Though, we should probably un-mark it too, but, I'll do that separately for all langs.
maciejdudko
requested changes
Oct 15, 2025
Comment on lines
12
to
13
| */ | ||
| @Experimental | ||
| public final class PollerBehaviorAutoscaling implements PollerBehavior { |
There was a problem hiding this comment.
This needs to be restored.
Comment on lines
-8
to
9
| */ | ||
| @Experimental | ||
| public class PollerBehaviorSimpleMaximum implements PollerBehavior { |
There was a problem hiding this comment.
This needs to be restored.
There was a problem hiding this comment.
This one I'll just keep the removal right now honestly, it was never really experimental since this just delegates to the old behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://chatgpt.com/codex/tasks/task_b_68e97eccfc2883318321fef725cebb09