-
Notifications
You must be signed in to change notification settings - Fork 180
Remove experimental status from worker tuners #2683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
238741a
17bd982
40824b5
86bfcfb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| package io.temporal.worker.tuning; | ||
|
|
||
| import io.temporal.common.Experimental; | ||
| import java.util.Objects; | ||
| import javax.annotation.Nullable; | ||
|
|
||
|
|
@@ -11,7 +10,6 @@ | |
| * <p>If the server does not support autoscaling, then the number of pollers will stay at the | ||
| * initial number of pollers. | ||
| */ | ||
| @Experimental | ||
| public final class PollerBehaviorAutoscaling implements PollerBehavior { | ||
|
Comment on lines
13
to
15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs to be restored. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks. 🤦 |
||
| private final int minConcurrentTaskPollers; | ||
| private final int maxConcurrentTaskPollers; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,11 @@ | ||
| package io.temporal.worker.tuning; | ||
|
|
||
| import io.temporal.common.Experimental; | ||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * A poller behavior that will attempt to poll as long as a slot is available, up to the provided | ||
| * maximum. Cannot be less than two for workflow tasks, or one for other tasks. | ||
| */ | ||
| @Experimental | ||
| public class PollerBehaviorSimpleMaximum implements PollerBehavior { | ||
|
Comment on lines
-8
to
9
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs to be restored. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one I'll just keep the removal right now honestly, it was never really experimental since this just delegates to the old behavior. |
||
| private final int maxConcurrentTaskPollers; | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,6 @@ | ||
| package io.temporal.worker.tuning; | ||
|
|
||
| import io.temporal.common.Experimental; | ||
|
|
||
| /** The base class that all slot info types used by {@link SlotSupplier} extend. */ | ||
| @Experimental | ||
| public abstract class SlotInfo { | ||
| SlotInfo() {} | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional to also move poller behavior out of experimental too? If so, it's still marked experimental inside
WorkerOptions.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this wasn't intentional, good catch. Though, we should probably un-mark it too, but, I'll do that separately for all langs.