Skip to content

Conversation

@arya-girish-k
Copy link

@arya-girish-k arya-girish-k commented Oct 8, 2025

Description

Add regex validation in ibm_catalog.json

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This PR enables input validation in the UI for several string variables by leveraging the value_constraints array defined in the catalog. These constraints will be used by the UI to validate user input at runtime. The changed variables include: prefix,existing_secrets_manager_instance_crn,existing_kms_key_crn,existing_kms_instance_crn.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@arya-girish-k
Copy link
Author

/run pipeline

@arya-girish-k
Copy link
Author

/run pipeline

@arya-girish-k
Copy link
Author

/run pipeline

@arya-girish-k
Copy link
Author

arya-girish-k commented Oct 21, 2025

Tested the variables against different patterns, including null values, incorrect inputs, and correct inputs. Corresponding screenshots are attached below.

  • Prefix:
The prefix to add to all resources that Pasted Graphic 12 Pasted Graphic 13
  • existing_kms_instance_crn:
Pasted Graphic 17 Pasted Graphic 18 Pasted Graphic 22
  • existing_kms_key_crn:
The value provided for 'existing_kms_key_crn' is not valid Pasted Graphic 20 Pasted Graphic 23
  • existing_secrets_manager_instance_crn:
Pasted Graphic 14 existing_secrets_manager_instance_crn © existing_secrets_manager_instance_crn ®

@arya-girish-k
Copy link
Author

/run pipeline

@arya-girish-k
Copy link
Author

/run pipeline

@arya-girish-k
Copy link
Author

/run pipeline

Copy link
Member

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocofaigh
Copy link
Contributor

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants